Cycle 390-399 focus : Stabilization, quests end. Changeset 394 (1972) is up ! Scripts, Teleport system, Seven Signs, Organization, Bugfixes Due to some IOOBE (shyr report), which was leaving 7S gatekeepers unusable, both trunk and diff 394 are impacted. Consider to re-download them if already applied.

Last aCis updates

Tryskell · 294 · 277459

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #285 on: January 02, 2020, 05:41:34 PM
Changeset 386 (1497)

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.

MariaDB / SQL tables, Scripts, Bugfixes, Organization

MariaDB / SQL tables
   - Consider to download latest MariaDB (10.4.11 at the date of this note) and transfer your db to it. MySQL is considered legacy.
   - Following tables are edited : accounts, auctions, augmentations. More will come with time, until all are optimized and follow convention.

   - Addition of Q120. Ty StinkyMadness for adaptation.
   - Addition of Q343, based on L2J's ivantotov script. Fix memoStateEx to fit L2OFF.
   - ShadowWeapon script
      - Add 10 missing entries out of 90, out of 3 multisells.
      - Add exchange option to Ranspo, as depicted on L2OFF.
   - Q101 : add missing quest items in registered items list. Ty Rootware.
   - Q336 : add missing npcId in addTalkId. Ty p0w3rf1y.
   - Q626 : make the quest repetable and party friendly, according client infos. Ty p0w3rf1y.
   - Fix Boat stop behavior upon harbor reach (both regular and busy states), leading to memory leak.
   - Fix IOOBE over GeoEngine#findPath (trying to set player on non-existing layers), based on Hasha fix.
   - Fix movement issue related to route cutting edges. Ty vladalien.

   - Orcs Mystics are considered as FIGHTER, and not MAGE anymore (22nd May 2007 patch note). Ty shyr.
   - Allow non stackable items with amount > 1 over create_item. Limitation based on inventory slot amount.
   - Second layer of fixes for enchanted item buy possibility.
      - Add missing messages for buy/sell enchanted items.
      - Add missing OperateType.NONE, which fix stuck behavior upon fail (casting a skill, setting on NO_STORE zone, etc).
      - Add ItemRequest#_enchant + related checks.
   - Fix Dice roll vector.
   - Fix SchemeBuffer duplicate key exception. Ty Sahar.
   - Revert part of 385 related to CC edit, fixing CCE about Raidboss.
   - Fix SecondClassChange "congratulations" htm.
   - Don't disband Party on DISCONNECTED leader (as tested on AdvExt).
   - Add missing zone data related to rev 384. Implement it under new enum SpawnType, based on StinkyMadness suggestion.
   - Server bypass floodprotection is lowered from 500ms to 100ms (lowest secured value, less painful for user).
   - Add SpawnLocation#getLocationWithOffset.
   - isVisible refactor, ty StinkyMadness.

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.
« Last Edit: January 05, 2020, 12:25:52 PM by Tryskell »
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #286 on: January 07, 2020, 06:36:43 PM
Changeset 387 (1541)

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.

LS rework, Quest related edits, Chat related edits, Organization

LS rework
   - Generate enums package for LS, and extract existing enums to it.
   - Generate data (sql and manager) package, and move all related classes to it.
   - Replacement of password algorithm from Base64 to BCrypt. Ty SweeTs.
   - Load all Account (previously AccountInfo) in memory, to avoid pointless SQL manipulation and generating/destroying Accounts objects.
   - Extract related content from multiple classes and generate AccountManager and IpBanManager out of it.
Quest related edits - Ty Hasha
   - Quest system edit
      - Complete the javadoc + cleanup.
      - QuestTimer storage is simplified (all timers are stored on same level).
      - Quest#onEvent is dropped, onAdvEvent prevails.
      - Add the possibility to cancel specific QuestTimer based on multiple criterias.
      - Implement Quest#onTimer, moving timer based events from onAdvEvent.
      - Quest#onGameTime and Quest#onSiegeEvent got now parameter for easier usage.
      - Make an extensive use of onDecay on all quests.
      - All quests are edited to spawn only one instance of a quest monster at a time.
      - Remove boolean flag isRepeating over Quest#startQuestTimer ; cut that method in 2, Quest#startQuestTimer and Quest#startQuestTimerAtFixedRate.
   - Quests
      - Introduce SecondClassQuest abstract class, holding shared content between all 2nd class transfert quests.
      - Q021 : Add few missing sounds and HTMs.
      - Q242 : Fix the Fallen Unicorn issue.
      - Q619 : Introduce droplists of relics for 4sep and IT.
      - Fix retail typo "Neidrahu" > "Nidrah" on all HTMs ("Nidrah" being the reverse of "Hardin", the necromancer).
      - Q334 addition, ty Rootware.
Chat related edits - Ty Hasha
   - NpcSay : added more constructors, javadoc
   - CreatureSay (Say2)
      - added more constructors, javadoc
      - updated packet structure, removed _npcString (IL client does not use NpcString)
      - removed systemmessage parameters, they are not used by client
      - updated parameter names, added some explanation
      - updated the usage of packet, whenever possible, changed to NpcSay(shorter packer name (string) -> npcid (int))
   - Introduction of new enum SayType for chat type.
   - Added NpcStringId container, based on L2OFF fstring.txt content.

   - Add SevenSignsManager#getLosingCabal(), rename SevenSignsManager#getCabalHighestScore() > getWinningCabal().
   - Delete CabalBuffer instance. Move behavior to AI script, as group.CabalBuffers. Behavior is taken from L2OFF GF (same than IL).

Note: Prefer NpcSay over CreatureSay, when having a need for creature (with NPC ID) to speak.

PS : The transition between Base64 and BCrypt for password encryption is left to live servers owners, but the idea is to edit used algorithm of "password replace feature" using BCrypt on your existing account panel, and request your users to edit their password to be able to log on.

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #287 on: January 17, 2020, 09:44:42 PM
Changeset 388 (1562)

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.

Env drop, PartyMatching, Quests, Bugfixes, Organization

Env drop - Ty Hasha for debug.
   - Drop Env and Lambda, which were retaining a lot of pointless variables.
   - Add missing "base" functions, and make a use of it.
   - All FuncHennaCON/DEX/... are merged into FuncHenna.

      - Merge PartyMatchWaitingList and PartyMatchRoomList into PartyMatchRoomManager.
      - Move PartyMatchRoom on, make it use AbstractGroup.
      - Delete package model.partymatching.
      - Related packets are cleaned. Methods are generated on appropriated classes to make it cleaner.
      - Fix all possible CMEs due to unappropriated containers, fix one possible NPE.
      - Rework the changeLeader management to avoid a client crash.
      - Add the missing max member amount check.
      - Rework waiting list behavior to fit with L2OFF.
      - Set the location as "1", to avoid a client crash. Put a TODO, as we miss needed implementation to code it as it should.

   - Q351 : Fix reward. Ty p0w3rf1y.
   - Q025 addition. Ty roko91 / Hasha.
   - Q335 addition. Ty RooT / Hasha.

   - Fix login system, reverting Account cache system.
   - Clan skills aren't rewarded on Player relog if reputation < 0.
   - Clan skill, upon acquisition, isn't rewarded if reputation reaches 0.
   - Add a missing Config.MINIMUM_CLAN_LEVEL use over ClanMember.
   - Fix Sand Cloud, Heroic Grandeur, Heroic Berserker, Invocation skills.
   - Rework ForestOfTheDead in order Npc references are correctly exploited + some cleanup. Ty Hasha.
   - Fix HP/MP Clan Hall regen calculation. Ty p0w3rf1y.
   - Save ClanHallFunction upon creation. Ty p0w3rf1y.
   - Optimize packet sending over Clan skill acquisition.

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #288 on: March 07, 2020, 04:53:06 PM
Changeset 389 (1660)

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.

AI rework, Organization, Bugfixes

AI rework - ty bowling4soup
   - Drop all redundant parameters (_skill, _target,...). We now use parameters from Intention.
   - Merge setNextAction and setNextIntention behaviors.
   - Add all missing queued actions (sit/stand, move/stand, etc).
   - Stacking attacks don't bug anymore, it is now processed by queue intention.
   - Skills (toggle skills included) are now queued if a cast is already occuring.
   - TamedBeast got now its own AI.
   - Drop following AiEventType : STUNNED, PARALYZED, SLEEPING, ROOTED, CONFUSED, MUTED, AFRAID, FAKE_DEATH and their related AbstractAI#onEvt. Merge all start/stop methods with the few uses upon skills.effects.
   - Add following IntentionType : USE_ITEM, FAKE_DEATH.
   - AdminEditChar#gatherCharacterInfo is slightly edited.
   - Add Creature#_hitTask and _bowReuseTask to track current attack, giving the possibility to deny launched attack.
   - Attack stance activation has been reworked.
   - Shift use is now taken in consideration for attack, cast, pickup, interact and follow intentions.
   - Generate CreatureAttack and CreatureCast (doCast got now a int, int version for easier usage) based on Creature content. Organize Creature leftover.
   - Many comments over skills are cleaned up.
   - Introduce ElementType enum, which got embedded vuln/res Stats for easier method process. Skills are edited accordingly. Fix few skills elements.
   - Split enums from NpcTemplate to their own classes (NpcAiType, NpcRace, NpcSkillType).
   - NpcRace got embedded vuln/res Stats for easier method process.
   - CreatureStat is cleaned up (javadoc included).
   - Stat related calculation (STR, DEX, INT,...) is now processed only on PlayerStat, which avoid 300k calcStat calls on server loading (and probably far more on regular exploitation).
   - Addition of cantBeNegative() on Stats for easier method process.
   - Merge Formulas#calcPAtkSpd and Creature#calculateTimeBetweenAttacks into Formulas#calculateTimeBetweenAttacks. Introduce a security limit of 100ms. Fix it using AdvExt as reference.
   - Add clone() override upon Point2D, Location and SpawnLocation - make a use of it.
   - Generate Creature#fleeFrom, Creature#moveUsingOffset and Npc#moveFromSpawnPointUsingOffset for easier management of such behavior.
   - Rename Creature#setRunning/setWalking > forceRunStance/forceWalkStance, Creature#setRunning(boolean) > setWalkOrRun(boolean). Proper override is done.
   - Move Creature#_AIdisabled to Npc#_isCoreAiDisabled.
   - L2Effect > AbstractEffect. Big cleanup + javadoc. Delete most EffectTemplate redundant variables, use getTemplate() content instead.
   - Generate EffectHolder, which is used by multiple packets.
   - Drop "applyCond" parseCondition call over attachEffect (useless/unused).
   - Generate SkillOpType / SkillTargetType enums. Edit skills.xml accordingly.
   - Split the 28 targets type in their own ITargetHandler, introduce TargetHandler. Generate gameserver.handler.targethandlers package.
   - Delete unused L2Skill removedOnAnyActionExceptMove and removedOnDamage boolean tags and associated subsystems.
   - DocumentItem, DocumentBase and DocumentSkill are moved to package.
   - L2Skill and AbstractEffect are moved to gameserver.skills package.
   - ExtractableProductItem and ExtractableSkill are moved to a new package on gameserver.skills.extractable.
   - Drop Attackable#useMagic, which was only used by QueenAnt script.
   - Distance related methods organization
      - Delete MathUtil#calculateDistance/checkIfInShortRadius. Delete Creature#isInsideRadius/getDistanceSq/getPlanDistanceSq. Generate methods on WorldObject, based on stored _position. Wipe all previous methods use, to simply use those.
      - Rework Point2D / Location distance methods ; they are now called distance2D/distance3D and isIn2DRadius/isIn3DRadius for proper usage.
      - 3D version of distance checks are now deployed on more places (all skill casts, most of NPC behaviors). 2D is still used for movement and some attack aspect to avoid problems.
   - Rename 3 packets related to PartyMatch system.
   - Delete official adena reward out of Q127 (exploitable).
   - Q367 rewrite using L2OFF. Fix quest exploit.
   - Fix player freeze (cant move/attack but they can chat). Ty zemaitis.
   - Fix MotherTree default value process over affectedRace. Ty p0w3rf1y.
   - Crappy Buffer can now handle exotic level, simply use "level" flag. All flags except skill id are now non-mandatory. Some cleanup + Javadoc.
   - Fix aggro about positive effects upon Attackable. Ty p0w3rf1y.
   - Rework HotSpringDisease script, adding missing events. Ty p0w3rf1y for report.
   - Fix normal and pvp flag timers. Ty p0w3rf1y for report.
   - Effects with stackorder 99 aren't cleansable anymore (raid Curse, anti Strider slow, 'BOSS' tagged buffs, signets effects, etc). Ty p0w3rf1y for report.
   - Signet symbols are fitting AdvExt (not cleansable, duration 8sec, few effects differ).
   - Provide correct visual timer upon debuff. Ty SLugeR.
   - Fix Cancel behavior (randomly chosen, works on any Creature, doesn't cancel specific effects (charms, noblesse...)) - Ty SlugeR.
   - Fix invalid encoding over Q021#31524-06a.htm. Ty RooT for report.
   - Add 5600-5699.xml, holding Apella sets triggered skills. Since they aren't existing client side, client got visual issues. Nothing I can do about it, except using "real" existing ids or edit client (which I won't do).
   - getDestination() isn't edited anymore on the fly, NPCs shouldn't "visual jump" anymore from one position to another (case of random walk, fear).
   - SetupGauge is also set for FUSION or SIGNET_CASTTIME cast.
   - Drop the few IDLE intentions on scripts.
   - Rework Orfen script :
      - The check task is set to 10s instead of 60s.
      - There is no more walking behavior. Fix a NPE in the same time.
      - Use of NpcStringIds.
      - Add missing 20% chance paralysis upon onAttack.
      - Add missing curses check (raid + antistrider slow).
   - Implement PartyMatch system AutoJoin button.
   - Fix the available rooms list on PartyMatch system to fit with AdvExt. They shouldn't be filtered.
   - Reset Pvp flag and unequip Adventurer's weapons upon karma kill. Ty p0w3rf1y.
   - SiegableHall - misc
      - Fix CastClassException over getAttackerClans().
      - Add missing SiegableHall content over RequestJoinSiege/RequestSiegeAttackerList. Add proper CP_CS_MANAGE_SIEGE usage.

Movement is still experimental. The status IS NOT OK for LIVE servers. MoveToPawn behavior still need to be fixed.
Siegable Hall isn't tested, and probably need further development. Those CHs are normally fully working regarding owner administration.
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #289 on: April 19, 2020, 12:27:33 AM
Changeset 390 (1785)

Ai system rework - part II, Movement - part II, Geoengine, Debug, Cubic system rework, Admincommands, Skills, RecipeBook, Organization, Bugfixes

Ai system rework - part II - ty bowling4soup
   - Fix following issues introduced in previous revision :
      - Cast on too far target block other actions.
      - Fix INTERACT behavior, when already near the target (case of shops, for exemple).
      - Fix randomly stopping attack action when using poles.
      - Move updatePvpStatus from doAttack to onHitTimer (in order pvp flag occurs when the hits occurs).
      - Fix a problem when pushing sell/buy button while being already under animation effect.
   - Fix SummonItem cast, generating SummonCreature skillhandler - cast of such items can now be properly interrupted.
   - Add ATTACK intention for nextActionIsAttack() skills, even if skill failed.
   - Fix an issue over RequestTargetCanceld, rename it to RequestTargetCancel.
   - Few tasks (effects, hp/mp regen, decay) are now properly disabled over deleteMe().
   - Add missing ActionFailed uses over thinkPickUp checks. Ty Djwegas for report.
   - Rework most of INTERACT behavior (onAction / onActionShift).
Attack / Cast - ty bowling4soup
   - Rework entirely both processes :
      - Moved all the checks out of doAttack, doCast. Generate canAttemptCast, canDoCast out of it. Implemented hierarchy.
      - Reorganized getTargetList so that targets are only calculated once during onMagicSkillLaunched.
      - Generate doToggleCast, doInstantCast, doFusionCasttimeCast to avoid to use regular cast process.
   - Toggle skills properly stops the Player. Message is sent for both activation/desactivation.
   - Add missing CHARGEDAM over L2Skill#isDamage() - those skills can now be used as part of CTRL key.
   - All methods related to isAttackableBy / isAttackableWithoutForceBy are now verified using L2OFF.
Movement - part II
   - Creatures (players excluded) don't use moveToPawn as follow state anymore. Ty shyr for report.
   - Summons' summon offsets are now secured, and retail-like (8 possible locations).
   - Fix the desynchronization between multiple direction switch. Ty bowling4soup.
Geoengine - ty Hasha
      - Fix GeoEngine#canSee must succeed, if all iterated points pass checks.
      - Dropped all "getXXXOriginal" methods.
      - Updated LoS to new logic, dropped redundant methods. Now applicable to all IGeoObjects as targets, not only Doors.
      - Renamed "canSeeTarget(WorldObject, Location)" to "canSeeLocation" to prevent misplacing, it has different LoS mechanism.
      - Fix getValidLocation(), which was enforcing geo position, even if tested position was good (item drop position, etc).
      - Javadoc, cleanup.
      - Dropped all "getXXXOriginal" methods.
      - Updated all methods with IGeoObject - target to be ignored.
      - Javadoc, comments update.
      - Dropped all "getXXXAbove/Below" methods, we access these data via "getIndexAbove/Below" and "getHeight(index)"

Debug - ty Hasha
   - Zones now use ExServerPrimitive for visual show.
   - Add a Player pool of ExServerPrimitive packets for debug usage. Multiple debug can coexist.
   - ExServerPrimitive are chained when max capacity is reached, to avoid client crash/lag.

Cubic system rework
   - Big cleanup over related files.
   - Life cubic activation rate is now affected by a %, based on friendly target's percent HP loss.
   - Life cubics don't heal anymore summons (part of CT1 patch note).
   - First activation time is now delayed, and not instant anymore.
   - Summoning an already summoned Cubic now refreshes the timer of already existing Cubic, and don't summon another Cubic.
   - Summoning a Cubic while being filled up replace the proper Cubic (aka, the first summoned on the queue).
   - Delete following commands : addlevel, edit_character, current_player, char_manage, teleport_character_to_menu, add_exp_sp_to_character, add_exp_sp, remove_exp_sp, setkarma, setrec, settitle, setname, setsex, setcolor, settcolor, setclass, setlevel.
   - Add //set command, which merge following commands : access, karma, rec, title, name, sex, color, tcolor, class, level, exp, sp. 2 admin panels are dropped, due to //set implementation.
   - Add //test command, which is a blank command used for any type of developement purpose.
   - Add //show (clear|move|path) admincommand. You're now able to see movement of any character (player/monster).
   - Implement AURA_CORPSE_MOB SkillTargetType, used by Festive Sweeper.
   - Add missing stats on Zealot. Ty
   - Add missing ssBoost info on Whirlwind. Ty p0w3rf1y.
   - Edit power of Wild Cannon. Ty p0w3rf1y.
   - Shield Slam duration edited from 2min to 1min. Ty xblx.
   - Drop BEHIND_AREA SkillTargetType (unused).

   - Add RecipeBook container, handling all recipe processes.
   - Recipes are now saved/deleted on add/remove, not on Player disconnection. Ty Reynald0 for the idea.

   - Cleanup "Change Subclass - Action" redundant behaviors. Slight edit on Player#setActiveClass.
   - Edit all offset related methods from Location/SpawnLocation. Ty Hasha for help.
   - ItemInstance#dropMe is reworked.
   - Earthquake packet is reworked. Add missing isNpc parameter, ty RooT.
   - Put .gitignore rule about log folder.

   - FloodProtectors class now uses a nano approach, instead of ms. Add MoveTime FP.
   - Fix Player#disarmWeapon. Ty Djwegas.
   - Add checks over buy/sell/manufacture processes to avoid packet crafting.
   - Remove whisper check about equal receiver<>emitter.
   - Add missing Antharas Earthquake effect, put retail values for Dimensional Rift.
   - Fix scenario where FREIGHT items are stuck on the ground after dropping them. Ty p0w3rf1y.
   - Implement missing AcquireSkillDone serverpacket.
   - More Location#clone() usages.
   - Shout, trade and all chat aren't blocked by Blocklist anymore.
   - Fix all int overflow issues. Ty HeeroYuy.
   - A shop can't be set if pvp flag is currently occuring.
   - An item buy/sell can't occur if either the shop or the buyer/seller is dead.
   - Fix few wrong SystemMessage :
      - Evaluate on null target.
      - Trade request on null target.
      - Few retail SystemMessages instead of custom.
« Last Edit: April 19, 2020, 12:39:20 AM by Tryskell »
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #290 on: April 30, 2020, 09:56:10 PM
Changeset 391 (1815)

Rev 390 bugfixes, Cubics part II, MailBBS, Geoengine, Skills, Organization, Bugfixes

Rev 390 bugfixes
   - Fix Guards / FriendlyMonster which don't see chaotic pets/summons. Ty shyr for report.
   - Summons can properly attack FriendlyMonster. Ty shyr for report.
   - Fix Summon follow stackoverflow.
   - Drop GM onAction shift behaviour, which automatically fixes missing ActionFailed issues (= stuck) over multiple shift uses.
   - Fix Non-Playable not being attackable in Peace Zones. Ty shyr for report.
   - Fix SummonItems cast process. Don't consume flute anymore. Ty shyr for report.
   - Item consumption is fixed (checked on canDoCast, done on doCast).
   - Remove USE_S1 message over item skill usage. Only item usage message should be sent.
   - Fix CreatureCast#onMagicHitTimer/onMagicFinalizer NPE. Ty shyr / xTakegawa for report.
   - Fix missing ActionFailed mackets over INTERACT/FOLLOW. Ty shyr for report.
   - Fix attackable states for ControlTower, Door, FlameTower.
   - Proper HP/MP checks over CreatureCast#canDoCast.
   - Fix invalid interact radius. Ty shyr for report.
Cubics part II
   - Add a 2s cast task (tested on L2OFF for at least 3/8 cubics, I suppose other do the same). Ty shyr for report.
   - All fireAction() submethods are cleaned up.
   - Implement CubicList, a Player related container.
   - Fix error upon sending mail. Ty Marcatu for the fix.
   - Move MailType to enums package.
   - Various optimizations + 2 potential NPE fixes.
   - Subject overview is limited to 30 chars to avoid layout deformation.
   - Fix double-layer issue, creature must follow the upper layer.
   - Fix Pig Chest skillId 2309. Ty RooT.
   - Fix 4624 skillId. Ty Vonak.
   - Fix effect power for 4 "chance" enchant routes. Ty xblx.
   - Add missing ItemSkills handler for Rice Cake. Ty shyr for report.
   - Implementation of //info, merging GM onAction shift content (summons, players, doors, npcs, statics objects), //summon_info and //npcinfo. The idea is to keep consistancy between GM and regular user behaviours.
   - Introduce Siege#announceToPlayers(SystemMessageId).
   - Rework Clan notice/introduction handling.
   - Add StringUtil#trim method, allowing elegant one-liner over String truncates handling.
   - Titles are now properly showing 16 chars, not 15.
   - Fix missing Clan buttons over character restart. Ty djwegas.
   - Add sps/bsps consumption upon Cubic/Servitor summon process.
   - SiegeFlag are now immune to Swoop Cannon damages. The task is now backed by a Future for doDie / deleteMe cases.
   - Drop FestivalMonster#isAttackableBy override (no specific mean).
   - Doors can now be damaged by regular skills. Walls are still not attackable by anything except SiegeSummon. Swoop Cannon can't target or inflict damages to doors/walls.
   - Fix orc mystic stat calculation. Ty Hasha.
   - Fix Admin teleport (Pirate Tunnel). Ty shyr for report.
   - Fix 3 HTM typos. Ty An4rchy for report.
   - Fix isMortal() concept ; limit the HP drop to 1 and not 0.
   - Properly set Attackable aggro over Summon doDie.
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #291 on: June 16, 2020, 10:09:14 PM
Changeset 392 (1847)

ExServerPrimitive, GeoEngine, Movement, Friend/BlockList, Enchant / Paperdoll

   - Color is now defined only via Color, rather than int. Extra methods are dropped.
   - Added addSquare, addRectangle methods for easier draw concepts.
   - Updated AdminGeoEngine "can_see" command graphics.

GeoEngine - ty Hasha.
   - Updated canSee, canMove and getValidLocation methods.
      - Now using exact line of sight/movement and checks all cells in the way, rather than using LoS/LoM approximation using Bresenham's line algorithm (see ).
      - Computation more heavy per each iteration. Performs approx 25% more iterations per path (25% more geodata cells evaluated). Still worth the accuracy.
   - Fix LoM check giving false positive result, when target is on "balcony".
   - Added first iteration of canFloat check, can be used for both, flying and swimming. Though the movement itself should handle all special cases (like water level, when swimming from bottom up).
   - Added new admin command "geo_fly" to check LoF.
   - Misc.
   - Rework moveToPawn / moveToLocation concept, for both Creatures and Players.
   - Introduce ValidatePosition debug (part of //show move) to visually see server<>client desync. Rework ValidatePosition.
   - Fix most of server<>client desync.
   - Fix dead/teleporting/disconnected over target follow.
Friend/BlockList systems rework - ty RooT.
   - Add missing packets and make a correct use of it.
   - Delete //silence && //tradeoff admincommands.
   - Move isBlockingAll concept to BlockList. Basic BlockList cleanup.
   - Add missing blocklist check over clan invitation.
Enchant / Paperdoll rework - ty RooT.
   - Drop all admin commands from AdminEnchant except "admin_enchant".
   - Drop enchant.htm, use quickbox instead.
   - //enchant doesn't work if the same enchant is already set.
   - Introduce Paperdoll enum. Rework most methods to use it.
   - Big cleanup of Inventory. Move some overriden behaviors back to PcInventory. Add Javadoc. Move ChangeRecorder out and rename it ChangeRecorderListener.
   - Delete 2 unused ItemInstance variables.
   - Few unused methods deletion over SendablePacket.
   - Move ItemLocation and ItemState to gameserver.enums.items.
   - XCast/XMove/XAttack now use generics, _creature is renamed _actor and now uses proper instance type which avoid cast.
   - Introduce back NPC castle guards. It will be kept like this until SpawnManager introduction.
   - Fix NPE related to castle guards / mercenaries Castle attribution.
   - Fix ControlTower castle guards spawns cleanup over doDie.
   - Fix NumberOutOfRange exception over hero fight loading. Ty BIGMANF.
   - Fix GMViewWarehouseWithdrawList packet. Ty StinkyMadness.
   - Fix Blacksmith Rooney spawn time. Ty vampir.
« Last Edit: June 16, 2020, 10:14:03 PM by Tryskell »
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #292 on: July 11, 2020, 10:16:10 PM
Changeset 393 (1913)

L2DatabaseFactory, CreatureStatus, tryToX, Weight system, Organization, Bugfixes

   - Rename it ConnectionPool. Move it to commons.concurrent, use static instead of Singleton.
   - Use MariaDbPoolDataSource instead of C3P0. Delete related JARs.
   - Indirectly fix "SQLNonTransientConnectionException: (conn=13) unexpected end of stream, read 0 bytes from 4" after inactivity time.
   - Update MariaDb connector to 2.6.1.

   - Merge CreatureStatus and CreatureStat. Use of generics, add Javadoc. Use internal variables instead of getter/setter.
   - Delete all getters used as shortcuts from Creature/Player.
   - Rename setCurrentX to setX (right for CP, MP, HP).
   - Move Cp related methods to PlayerStatus.
   - Delete all redundant StatusUpdate calls. Basically, whatever which was calling setX()- X being HP, MP, CP.
   - AddMp and reduceMp are slightly edited to avoid to call setMp if value isn't worthy to be edited. Implement CreatureStatus#addHp based on those.
   - Implement setMaxHp/HpMp/CPHpMp. Those are optmized to call StatusUpdate only once.
   - Intentions use direct methods to avoid to "guess" parameters type. It also shortcuts writting style by a lot.
   - Delete SkillUseHolder container/use, which was generating a lot of objects.
   - Players previous stance isn't hidden anymore by ACTIVE triggering IDLE. When a Player calls ACTIVE or IDLE, it goes directly to IDLE.
Weight system - Ty Hasha
   - Addition of PlayerStatus#isOverbuden (80% volume check), with uses.
   - Fixed pet weight calculation. AltWeightLimit applied to pets too.
   - Fixing AltWeightLimit config being double parameter read as int.
   - Fix potential bug, when removing weight penalty functions from Pet.
   - Fix multiple item extraction to first check available slot and than create items.
   - Update ConditionPlayerWeight to use weight penalty, updated XMLs.
   - Added missing WEIGHT_PENALTY stat, updated XMLs to AdvExt values.
   - Dropped Creature#_isOverloaded, as only Player and Pet may get overloaded. Overload solved by checking speed == 0, as L2OFF.
   - Added missing system message in MoveBackwardsToLocation.
   - Fixed Pet not getting effect of weight penalty.
   - Rename commons.concurrent > commons.pool.
   - Delete unused effect EffectCombatPointHealOverTime and EffectType.COMBAT_POINT_HEAL_OVER_TIME.
   - CreatureAttack#doAttack is correctly overriden in Attackable and Player cases.
   - Rename StatusType to ServerType. Rename related methods / variables.
   - Generate StatusType out of StatusUpdate packet.
   - Move _exp, _sp, _level to PlayableStatus.
   - Delete isChampion() concept. The whole custom is dropped.
   - Rework Formulas#calcCrit and calcMCrit.
   - Some Blow/Pdam cleanup.
   - Delete isBehindTarget() / isInFrontOfTarget(). The concept is wrong, since effected isn't specially actual getTarget().
   - Move isBehind / isInFrontOf / isFacing from Creature to SpawnLocation. Any WorldObject can now call it.
   - Rework targetLost to handle more checks, rename it isTargetLost.
   - Siege#announceToPlayers is renamed Siege#announce and allow SiegeSide as parameters (making it possible to call it independently for ATTACKER and DEFENDER, or both).
   - Delete Player#isInSiege concept, since it's wrongly used (used as a mixed "isSiegeParticipant" and "isInSiegeZone" checks).
   - GMs are now affected by death penalty and by castle foreigner teleport.
   - 3200-3299.xml is partially fixed (reviewed 15+ item skills).
   - Add missing check regarding Baium Angelic Vortex. Ty Kitsos.
   - Fix SiegeGuard NPE during attack. Ty henrique for report.
   - Fix "Need to press ctrl to attack siege guards". Ty henrique for report.
   - Fix SiegeGuards respawn upon end of a Castle siege. Ty henrique for report.
   - Fix Guards can't be debuffed at any case. Ty shyr for report.
   - Add back interact possibility with FriendlyMonster. Ty shyr for report.
   - Fix Gatekeeper CANNOT_PORT_VILLAGE_IN_SIEGE condition. Ty Denzel for report.
   - Add missing Broadcasting Towers spawns. Ty henrique.
   - Introduce INTERACT for Summons. It basically is a MOVE_TO with shift possibility.
   - Fix a ClassCastException over PlayerAI interaction (boards use).
   - Fix a ClassCastException over RequestActionUse (throne use). Ty henrique for fix/report.
   - Summons react to shift command over attack.
   - Summons return back to owner if isTargetLost is triggered (interact, cast, attack).
   - Summons owner follow status is now broken while sent to attack/interact.
   - Add missing SUMMON_GAVE_DAMAGE_S1. Correct override. Ty StinkyMadness.
   - Summons can't be sent to attack dead targets. Ty StinkyMadness.
   - Fix "When you're running and click on npc to speak with it, your char only stops on client, but continues to run on server". Ty SlugeR for report.
   - Fix "Trying to cast skill + moving teleports you on client". Ty SlugeR for report.
   - Fix proper uses of tryToSit/tryToStand. You shouldn't "tryTo" when using a skill, but directly execute it.
   - Fix pick up animation timer. Ty SlugeR.
   - Add retail C5 implementation of Charm of Courage.
   - Fis death on siege properly decreases xp by 1/4.
   - Add proper check messages for siege summons attempts.
   - Fix siege process timer, based on AdvExt.
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!

Online Tryskell

  • The cute dwarf
  • *
    • Posts: 4.100
    • Cookies: +83/-2
Reply #293 on: October 03, 2020, 02:23:13 AM
Changeset 394 (1972)

Scripts, Teleport system, Seven Signs, Organization, Bugfixes

   - Introduction of Tutorial / NewbieGuide - Ty howlrang/Marcatu for initial cleanup of L2J script.
   - Fix following quests : 101, 102, 103, 104, 105, 106, 107, 108, 257, 260, 265, 273, 293.
      - Rewards are done using rewardItems instead of giveItems.
      - Fix ss/sps beginners rewards amount.
      - Rewards are now secured by a PlayerMemo var instead of QuestState var, making it exploit-free (case of 257, 260, 265, 273, 293).
   - Q105 now rewards regular ss/sps ng, aswell as potions.
   - Q260 / Q265 reward formulas are fixed using L2OFF.
Teleport system
   - Revamp whole teleport system, using lord_rex initial share.
   - goto/tele/etc bypasses are deleted, and replaced by only those 2 versions : instant_teleport and teleport_request. Move the teleport logic to Npc. Children classes can override isTeleportAllowed(Player).
   - Implement TeleportType enum, based on L2OFF AI content.
   - Implement instantTeleports.xml. Those teleports only check Npc#isTeleportAllowed(Player), while regular teleports check siege, item consumption and Npc#isTeleportAllowed(Player).
   - Improve teleports.xml, reparsing the content using L2OFF. The model now holds the Castle, teleports are organized by npcId and by TeleportType. The initial data was double check with RooT's work, allowing to add 10 missing ids and cut 60+ pointless ones.
   - The HTM which shows teleports is now built out of nothing from data. All existing, related HTMs are deleted (scripts and regular teleporters).
   - Add few missing "-pk" HTMs (30162, 30836, 31964).
   - Add (back ?) FREE_TELEPORT config.
   - Rename "teleporter" HTM folder to "gatekeeper" (to match class names).
   - Rename script ToIVortex > DimensionalVortex.
   - Add castle chamberlains teleports aswell - parsed from L2OFF GF, since the content of Vanganth and AdvExt was lacking. They are not yet implemented.
Seven Signs - Ty Hasha.
   - Updated all HTMLs to L2OFF GF, formated them, fixed obvious mistakes, typos and names.
   - Added missing HTML with - not enough adena to purchase Records of Seven Signs.
   - Fix xxxx_priest_2c.htm to not containCatacomb/Necropolis teleport location link (Seal of Gnosis owner lost -> no teleport).
   - Fix "Failed to retrieve cabal from bypass command." upon trying to contribute Seal Stones while Seven Signs is in Competition period.
   - Characters with 1st class transfer can now join any side.
   - Add //show html, which toggles on/off the HTML path for GMs (similar to L2OFF). There is no associated config, and is set to false by default.
   - Secure //set class, which now checks dummy ClassIds, and provide more infos upon fail.
   - Introduce QuestState#rewardNewbieShots method for easier management of beginner reward.
   - RadarList#addMarker/removeMarker now accept a Location as parameter.
   - QuestState#addRadar/removeRadar only accept Location as parameter.
   - Hardcode all Locations used in Quests for easier management. Replace some int[][] for Location[].
   - MIMYU SpawnLocations are downgraded to Locations.
   - Delete all unused SkillTypes.
   - Drop all "Alt" and "Game" from either Config .properties or java side. Few Config renames.
   - Cleanup all checks regarding TAKE_CASTLE, STRIDER_SIEGE_ASSAULT, SIEGE_FLAG and SUMMON_FRIEND - moving methods from Player to dedicated handlers.
   - Generate NpcTalkCond enum. Rename and generate on Npc #validateCondition(Player) > Npc#getNpcTalkCond(Player), which now acts as overriden. Cleanup all uses.
   - Fix Benom spawn timer.
   - Fix trade NPE, upon empty lists pushing "Start" button.
   - Fix Broken actions upon invalid trade windows checks.
   - Fix Summon Friend and alike skills. Remove the 50 radius check. Add a SystemMessage and avoid the cast on yourself.
   - Fix Gate Chant, adding SUMMON_PARTY SkillType.
   - Fix Elpy AI. Ty Bruns87.
   - Allow Config.OLY_MIN_MATCHES to be correctly spread over queries when a Config reload occurs.
   - Fix a stackoverflow over siege end. Ty Kitsos for report/fix.
   - Fix StriderSiegeAssault, using skill target instead of getTarget().
   - Fix bow attack reuse over CreatureAttack#stop() call. Ty MonKEY fo report.
   - Delete active siege check on Wyvern Managers + class cleanup.
   - Switch Schuttgart CHs to correct order, fixing CHs doors and spawn.
   - Auto loot Config properly checks inventory size.

PS : Q257 is now race bound to HUMAN. While NOT RETAIL, it looks like a NCSOFT fail :
   - It defeats the C3 layout being than "all races get access to 13k ss / 6k sps".
   - Out of 13 newbie quests, it's the only "race unbound" quest.
If you manage to find any retail info about why it has been done that wrong way, I'm willing to revert it.
« Last Edit: October 06, 2020, 12:36:15 AM by Tryskell »
Code: [Select]
Triskel does not speak with foolish fellows who do not know their profession!