Last aCis updates

[Tryskell]

Changeset 296

Antharas, RBs timers, Misc

Antharas
   - addition of death cinematic (ty UnAfraid for the script).
   - Antharas use his skills following L2OFF script. And yes, the Rnd.get() fuckfest is retail-like.

RBs timers
   - fix GBs/RBs timers to follow L2OFF values. The biggest change is regular bosses going from 12-36h to 12-60h (36 +- 24) && Zaken/Sailren timers.
   - random timer is modified to handle hours by hours, not ms by ms (* 3600000 is made after the Rnd is selected).
   - random timer on GBs is supposed to be +-, not only + (edition of all GBs AI scripts).
   - drop of RaidMinRespawnMultiplier and RaidMaxRespawnMultiplier configs. I don't like them. Don't ask.
   
Misc
   - addition of ZoneId (exemple : L2Character.ZONE_PVP > ZoneId.PVP).
   - fix arenas XP loss, ty Root for report. You still loss XP inside arenas if killed by anything except playable (avoid RB exploits).
   - you don't lose XP while in siege, if you were involved by the siege (either playable or siege NPCs).
   - fix new clan member "rank" (you are registered in main clan, not on 5th grade). Ty SweeTs.
   - fix an invalid pvpflag scenario (summoner is out of the arena, but summon/pet is in : attacking the summon/pet makes you purple).
   - reorganization of L2PcInstance isAutoAttackable(), which also fix 1 issue about clan member check (the clan member check was made on attacker's objectId, but attacker can be the summon...).
   - bring isInsideZone in L2Object, allowing to drop all casts.
   - addition of isInArena(), as it's often used (checks if a player is in a PVP zone but not in a SIEGE zone).
   - getWantsPeace() > wantsPeace(), modified for a boolean rather than int.
   
Notes :
   - getRespawnMinDelay() and getRespawnMaxDelay() are "overriden" on L2RaidBoss spawn to be used as fixed and random timers => (getRespawnMinDelay() + Rnd.get(-getRespawnMaxDelay(), getRespawnMaxDelay())) * 3600000.
   - isAutoAttackable is to test.

[Tryskell]

Changeset 297

Quests, Misc

Quests
   - addition of Q344, Q660 - ty Junior.
   - fix Q374/Q375, ty Tommy.

Misc
   - drop setIsFlying() and setIsRiding() method, using inheritance.
   - fix few skills : 6 summon skills (npcIds were messed up), missing nextActionAttack - ty Tommy.
   - fix toggle stopping movement action and next action stopping current action - ty xblx.
   - rename AI_INTENTION_X to X, and harmonize uses for CtrlIntention.X.
   - avoid to send a FOLLOW intention when clicking on yourself.

[Tryskell]

Changeset 298

Quests, Misc

Quests
   - addition of Q421, Q643.
   - FairyTree AI is melted with Q421 : killed tree spawns numerous ghosts, and ghosts speak when tree is under attack.
   - add 3 HTMs related to Q348, edit qItems to be qItems.
   
Knownlist
   - knownlist is reworked ; drop iterators, drop _knownPlayers and _knownRelation maps.
   - cleanup KnownListUpdateTaskManager (drop _failedRegions, merge cases), ty xblx.
   
Misc
   - npcs.xml is edited for Fairy Trees case : they become L2Monster, can't move, and got 3 minions.
   - fix ss/bss consumption for pets and summons, ty Tommy. No more sanity check.
   - fix Corpse Burst (power table) and Arrest(should aggro) skills, ty xblx.
   - fix StunSelf effect, ty Myazz.
   - revert part of rev 274 in order to fix short animations when you cast a skill (ex : raging force).
   - random misc

[Tryskell]

Changeset 299

Quests/AI, Knownlists, Misc

Quests
   - addition of Q218, Q223 (added Road Collector / Harpy Matriarch AI), Q348 (ty equip, fernandopm, Tommy).
   - Baium cleanup regarding statue animation, drop of _waker.

Knownlists
   - cleanup KnownListUpdate : merging checks, merging method updateRegion with the task, do an action only if given object is an L2Character, checks moved out of for loops and "final"-ized, fix an issue of timer.
   - _knownList is moved from L2Object to L2Character. Items and L2Static aren't associated anymore to a knownlist object.
   
Misc
   - fix a typo in getClosestTownName() method (S*c*huttgart).

[Tryskell]

Changeset 300

Scripts, Misc

Scripts
   - addition of Q222, Q232 (ty equip, Junior).
   - cleanup numerous quests (getQuestItemsCount > hasQuestItems, drop of "exitQuest(true)" on STARTED cases, misc). Need to do more, I was lazy to re-read all godamn quests...
   - fix DoctorChaos respawn time (for regular RB time).

Misc
   - fix revive animation, drop of _isPendingRevive and associated getter/setter - ty Kingzor / xblx.
   - cleanup ItemSkills && ScrollOfRessurection itemhandlers (fix SoR consumption, made on skill call not on item call) - ty Kingzor / xblx.
   - fix esc, target is supposed to be kept if you were casting a skill (but a second press on esc cancels the target)- ty dEvilKinG for report.
   - drop GM bypasses regarding inventory capacity (avoid to be filled at 105/80).
   - use of hasPet() when possible. hasPet() check doesn't check if != null (as instanceof is doing it).
   - fix Olympiads zone ids 7 && 8, and move all spawn points farer to center (ty Rainbow Dash).
   - fix the alert on console regarding Shadow Sense (ty Rainbow Dash).
   
To be perfectly honest I was lazy those days and some things haven't be tested, notably olys zones (if they're wrong, complain to Hasha :p) and quests changes (that's just code changes, shouldn't alter the logic).

[Tryskell]

Changeset 301

Olympiads, Quests, Misc

Olympiads - ty Hasha.
   - fix visual bug regarding participant HP bars.
   - fix visual bug regarding participants buffs bar refresh (for spectators).
   - wait time setted by default to 30sec.
   - rework spectators system.
   - drop ExOlympiadUserInfoSpectator packet (not used).
   - add 2 configs (AltOlyWaitBattle && AltOlyWaitEnd).
   - random cleanup.

Quests
   - cleanup numerous quests (notably Q163, Q166, Q171, Q294, Q296).
   
Misc
   - cleanup ClanTable - ty Hasha.
      - avoid to use getter/setter inside the file.
      - scheduleRemoveClan parameter is changed for L2Clan not int (avoid to read 4 times the Map to find the L2Clan).
   - cleanup L2Clan
      - avoid to use getter/setter inside the file.
      - Integer parameter > int.
      - Drop of L2Clan version for setEnemyClan / setAttackerClan. Integer survivor > int.
      - Edit deleteEnemyClan(L2Clan) / deleteAttackerClan(L2Clan) parameters from L2Clan to int (clanId).
      - simplify few methods (notably ".contains" which implicitely returns a boolean).
      - getAllSkills() is edited for getClanSkills().
      - drop of _skillList, 2 removeSkill(int/L2Skill) and getSkills() methods (L2JIL unused) - ty Hasha.
      - drop of addClanMember(L2ClanMember) method (private, 3 uses, 1 line method).
      - getOnlineMembers(int) loses his parameter.
      - addSkillEffects(), updateClanScoreInDB() methods are dropped.
      - rework setReputationScore(int) method in order to avoid to create 3 times (!) clan members list, and regenerate getClanSkills() for every member. Use of Math.min/max.
      - setHasHideout() / setHasCastle() renamed for setHideout() / setCastle(). Variables are also renamed.
   - L2PcInstance
      - the Map storing subclasses is initialized with instance itself, and final.
   - sorted maps for subclasses, macros and skill lists - ty xblx, Trance.
   - fix beginner shortcuts (self heal was overidden sit icon) - ty Kingzor.
   - fix one systemMessage, and 3 others (not used yet, so not visible) - ty Hasha.
   - drop of L2TIntObjectHashMap (only one use before, not used anymore).
   - fix an issue regarding clan skills give back once Olympiads are done, if clan reputation is <= 0.
   - fix top/bottom ; getting one OR the other doesn't mean you got both anymore (1 && 0 || 0 && 1 = 0, not 1). Ty Hasha.
   - Skills (need to do a lot more about skills...)
      - fix Focus Attack (set to 1, not add 1).

[Tryskell]

Changeset 302

Quests, Misc

Quests
   - addition of Q212, Q365, Q383

Misc
   - fix a double animation on custom L2ClassMaster. Ty Kingzor.
   - revert changes made on ExHeroList (not buggy anymore, but still not retail).
   - L2Clan (again)
      - drop addSkill(L2Skill) method - unused.
      - addNewSkill(L2Skill)
         - manages to regroup 3 others packet sending in an existing getOnlineMembers() loop (avoid creation of 3 clan members lists per skill addition).
         - avoid to send skill refresh packet if the clan skill doesn't match your rights.
         - the message saying you earned a clan skill is now broadcasted to all clan members, rather than only clan leader (create some stuff to clan chat about...)
      - setReputation
         - refresh members skill list (when an update is needed).
         - fixes an error introduced in previous rev (rep points update has to be made even if an update isn't needed).

[Tryskell]

Changeset 303

Headquarters, Four sepulchers, Misc

Headquarters
   - HPs are now properly setted, but during flag spawn (as we refactored npcs.xml, the NPC got 40HPs following L2OFF).
   - HPs is currently doubled when Noblesse HQ version is used (and not, as regular L2J, damages mitigation).
   - L2SiegeFlagInstance cleanup.
   - drop of SiegeFlagStatus.
   - show skill cast error message even out of castle area.

Four sepulchers
   - Q620 rework (HTMs renamed, simplified structure).
   - Wigoth doesn't burn a Used Grave Pass anymore.
   - You can choose your recipe correctly.

Misc
   - [301] fix an Integer > int issue : if parameter is an int, .remove( method of ArrayList removes by index, not by given object.
   - [301] revert an experimental code for ss/bss effect, which has been commited by negligeance (and was buggy).
   - fix a log warning related to a SystemMessage.
   - slight edit in targetReconsider() method in order mobs don't attack doors or invisible GMs (+ a lot more checks). Don't make anymore movement checks for "regular" targetReconsider (reserved for skills checks).
   - edit StatsSet logs, in order it gives info related to the missing stat.
   - L2CharTemplate/L2NpcTemplate got more values setted by default (if you have to create a custom template, you got minimum infos to care about).
   - drop unrelated/inheritated stats from doors templates (as it inherits from L2CharTemplate, not L2NpcTemplate, no need of exp/sp/rHand/lHand/etc).
   - add pdef/mdef of doors on admin shift click panel (more fashion).
   - fix an error in calcSiegeRegenModifer() formula (wasn't taking custom in consideration). Move method from double to boolean.
   - fix a concurrent issue on L2CommandChannel + basic cleanup.

[Tryskell]

Changeset 304

Karma, Misc

Karma
   - [L2J 6074] added retail karma drop/gain system.
   - KARMA_PLAYER_CAN_BE_KILLED_IN_PZ does only what the name suggests. Drop redundant checks on isInsidePeaceZone().
   - don't clean karma on death if ALT_GAME_DELEVEL is setted to False (as karma drop is related to xp loss upon death).
   - don't earn a PK point on summons/pets kills (but still earn karma).
   - drop 4 configs related to Karma calculation method.
   - restoring exp (via BSoR / res skills / GM commands add_xp) don't clean karma. Ty Zerador for report.

Misc
   - L2CastleTeleporterInstance cleanup, also fix an HTM typo. Ty sahar.
   - [L2J 6070] cleanup calculateRewards(). Multiple fixes and performances tweaks.
      - doesn't create an empty map if aggrolist was empty.
      - avoid to calculate xp/sp gain if attacker is dead.
      - limit the list of rewarders to L2PcInstance (avoid all checks regarding summons).
      - fix issue regarding summons/summoner damages (one was overwriting the other, now it cumulates).
      - calculations are based on total damage made, not on maxHP of the monster.
   - don't earn a PvP point on summons/pets kills.
   - cleanup L2Party (internal vars uses rather than getters/setters, party broadcast setted to 12s instead of 10sec).
   - drop useless itemhandler ChristmasTree.
   - beast ss/sps are desactivated on summon death + cleanup poor overidden use on doDie() (L2Summon, L2PetInstance, L2SummonInstance).

[Tryskell]

Changeset 305

Skills, Misc

Skills
   - fix Polearm Accuracy (422), ty djdiablo for the fix.
   - fix treasure keys, based on previous SoR rework. You will stop to harass me with this at least, for Elmoreden's love.
      - drop DeluxeKeys skillhandler, add Keys itemhandler. DELUXE_KEY_UNLOCK is considered as a Dummy skill.
      - you can't consume a key on dead chests nor mimics ones (invalid target message).
      - regular keys are debugged : can't use on doors, and it uses the deluxe handler. Add the 60% luck on Chests.java script.
      - ONLY regular/deluxe keys for treasure chests are debugged. Others (pagan keys ?) would eventually be fixed when I will know their uses.

Misc
   - summons don't intention-stuck anymore if they're broken during a skill cast (they will either follow you back or continue attack).
   - fix Anakim/Lilith "out" teleporters. Fix teleporters spawns, and players spawns to be centered on the "tile".
   - avoid to refresh twice overload and penalty checks at character restore.
   - fix package sell mode (must stay checked if previously checked), ty sahar for report.
   - added retail penalty system, ty devilking for patch.
   - edit config NoQuests for NoScripts, and make a use of it, ty Root for the idea.
   - peace zone stuff :
      - drop the different implementations of isInsidePeaceZone(), keeping one. As that method includes allowPeaceAttack() check, drop external checks.
      - summons can't force attack anymore players on peace zone. Instead, it will follow target. Drop also the message, as there isn't on L2OFF.
      
TODO
   - missing SAs / dual passive skills drop/add on refreshExpertisePenalty().

[Tryskell]

Changeset 306

Quests, MapRegionTable, Misc (known in future generations as "Hasha commit" or "fuck you Bingo quests")

Quests
   - addition of Q381, Q382, Q384 (ty Tommy, roko91, Hasha for sexy help)

MapRegionTable (ty Hasha)
   - merge TownManager and MapRegionTable.
   - fix an issue with regions, where dying from Valakas's Lair would lead to teleport back to TI Island (out of region array).
   - multiple code improvements and data update.
   
Misc
   - cleanup items consumption messages (destroyItemByItemId() got it embedded), ty Hasha.
   - addition of scrambleString(string).

[Tryskell]

Changeset 307

Quests, Misc

Quests
   - addition of Q215, Q216, Q217 (ty Erlandys * 3)
   - fix //reload for quests ; ty Hasha
   
Misc
   - fix symbols, ty Hasha. Sidenote : the issue came from rev 189. Before that rev, it was working correctly.
   - augmented weapons aren't shown anymore on NPCs sell shop.
   - toggles are desactivated upon teleport, ty djdiablo. ONLY REGULAR PLAYERS ARE AFFECTED, NOT GMS.

[Tryskell]

Changeset 308

Quests, Spawnlist, Misc.

Quests
   - rework Q005 (failed HTMs and quest logic ; one of the first quest we commited ?)
   - fix Q016 (qItem wasn't cleaned up on quest abort).
   - proper qItem checks on q038.
   - cleanup numerous quests (up to q050) to match aCis current standards (naming conventions and other misc). For info, scripts are WIP since 1,5y and since that time, my standards changed. I will cleanup them 50 by 50, or so.

Spawnlist
   - refresh the spawnlist logging spawns from L2OFF ; it notably will fix following issues :
      - add monsters than L2J IL never had (20+ new species added).
      - fixes any spawn which was under ground (Ant Nest for example), and fill empty locations (Orc Territory for example)
   - credits to mcbigmac for loggerExt.dll, dEvilKinG for the SQLization.

Misc
   - add numerous missing minions, using L2OFF spawnlist, ty dEvilKinG.
   - if you try to edit subclasses being registered on Olys, you become ineligible to fight, ty KaL.
   - refresh overload penalty for //setclass command, ty KaL.
   - addition of the clans ladder feature (schedule task + loading), ordering clans by their reputation score, ty KaL.
   - fix typo on loginserver, when you drop GS more than one time, ty KaL.
   - Basic cleanup of GameServerThread. isBannedGameserverIP() now works using banned_ip.cfg (eventual workbench to split servers/client IPs + XMLization of the .cfg ?).
   - arrows are correctly dropped/deleted (current equipped pack stays equipped), ty Erlandys.
   - added missing HTM dialog for Metheus, ty KaL for report.
   
PS : spawnlist *system* isn't retail-like, but L2J system will be kept as data doesn't suck anymore.
PS2 : some issues can happen with that new spawnlist, as it edits ALL existing spawns. Report on forums if any problem.

[Tryskell]

Changeset 309

Quests / scripts, Spawnlist, Misc.

Quests / scripts
   - cleanup numerous quests (up to q170 ; rework edited quests from previous rev again).
   - fix a NPE occuring in Q232 (ty roko91).
   - addition of MissQueen script + 4 multisells. Spawns are also handled by the script.

Spawnlist - ty dEvilKinG
   - addition of missing spawns for 2 catacombs (Heretic / Apostate).
   - drop of Miss Queen spawns (handled by script).
   - refresh fixed respawn time for L2OFF ones.
   - new feature : random spawn time (random + fixed = real respawn time). Edit npcinfo.htm.

Misc
   - added the missing "1h cleanup task" for ground-dropped CW, ty KaL.
   - [L2J 6136] Drop _attacking implementation and associated condition.
   - [L2J 6131 / 6137] Fists are considered as a dual attack weapon (players only). Drop the "dual" boolean parameter on calcPhysDam() && isUsingDualWeapon() method.
   - "Characters donning Formal Wear cannot use skills and magic. If they equip weapons or shields, the Formal Wear will automatically be unequipped.", ty KaL. Drop the check from CW which was unequipping FW to avoid double checks.

[Tryskell]

Changeset 310

Quests, Misc.

Quests
   - cleanup quests up to q250. Fix also few bugs/typos/logic on existing quests.
   - addition of Q214, Q219, Q231.
   
Misc
   - random respawn should be -+, not only +. Ty fernandopm for reminder.
   - cleanup AdminCreateItem handler, and add create_set command (integrated in itemcreation panel). Open the inventory window. Ty KaL.
   - the champion reward system is now bound to regular level restriction (deepblue drop).
   - add few missing teleporters spawns (catacombs related), ty dEvilKinG.
   - fix two issues regarding boats (deviant boat walking in the mountain, "merging" boats in Rune docks), and messages/timers. Ty KaL.
   
PS : that revision has been delayed because I played a lot and I'm not sorry about it !