Changeset 400 (2376)

Bugfixes, Organization

Bugfixes
   - Fix NodeBuffer exhaustion. Ty Hasha.
   - Add missing CLAN_MEMBER_GRADUATED_FROM_ACADEMY message use. Ty Kable for report.
   - Fix a visual issue over movement (attacking while target is on PZ).
   - Fix NPE over PlayableCast#canDoCast. Ty shyr for report.
   - Save hidden effects (eg. buffs under herbs) upon Player restart/logoff. Ty Gigi885 for report.
   - Fix calcPhysicalAttackDamage missing boost ss, prior to rev 399 formula refactor. Ty Denzel for report.
   - Fix following messages from effects :
      - S1_HAS_WORN_OFF and EFFECT_S1_DISAPPEARED are now used depending about effect left length time, and aren't called both anymore.
      - EFFECT_S1_DISAPPEARED is called if an added effect replaces an existing effect (equal or superior).
      - YOU_FEEL_S1_EFFECT is called on every effect application, and removed from skillhandlers and side systems.
   - Fix proper handling of long values into Config. Ty StinkyMadness for fix.
   - Allow offensive skill / attack over same clan/alliance under arenas. Ty Kable for report, Penacho for fix. Fix also few isInsideZone checks, where getActingPlayer() was tested instead of Playable (overriding Summon state).
   - Add missing getAttackSpeedMultiplier() over PetInfo. Ty stepforstep for report.
   - Fix //reload announcement. Ty Denzel for fix.
   - Clean target to avoid to get "ghost" target upon //recall. Ty RooT for fix.
   - Fix Q294 reward. Ty YulRun for report.
   
   
Organization
   - Added 9 missing NpcStringIds.
   - Extensive use of broadcastNpcShout.
   - Few SonarLint cleanup.
   - Few Clan method renames.
   - Delete ZoneForm#getDistanceToZone concept.

Big cleanup :

• Moved vladalien, bowling4soup from active developers to retired.
• Moved Sluger from active developer to Sidekick.
• Deleted "Outer Circle" membergroup (only Wreaper, from LU4 team, was part of it).
• Renamed "Supporter" to "Donator", and "Inner Circle" to "Supporter".
• Cleaned all existing "Supporters".

The concept evolved a little !

New freemium rules will apply at the 40th cycle.

Following systems are still maintained internally and publically :
    - "Changeset" ("release" on Gitlab) : a compilation of bugfixes reaching a state of stability, based on my own self-appreciation.
    - "Cycle" : a compilation of 10 "changesets", generally associated to a main goal.

Supporter rank
    - "Customer" rank will be now known as "Supporter". They will still benefit custom section from forums.
    - "Supporter" rank will be way more pricey : a one-time fee will be asked, then a monthly fee will be required to maintain your supporter rank.
    - Supporters will be directly registered to the Git.
    - Issues will be migrated on Git issues tab. Forums won't hold any issues anymore.
    - No more diff patches / trunk shares over forums. Forums won't hold it anymore. Changesets / releases are still pickable from Git.

Public Git
    - Public version is still maintained, and is now old of 1 year and not 10-19 revisions.
    - Stability state isn't guaranteed. It is shared as a "demo", to see aCis progression.

Contribution
    - You still can contribute to the pack with bugfixes, or via the "lab monkey". Your contribution can eventually lead to rewards (the most obvious being, free monthly fee).

Changeset 399 (2353)

Formulas, Scripts, Bugfixes, Organization

Formulas
   - HP/MP/CP - ty Hasha.
      - Unhardcode HP/MP/CP regen base values. Each class got now its own tables. Indirectly fix formulas (values aren't linear, but step-up every 10 levels).
      - Formulas are checked and tested using L2OFF (specific order maintained).
      - Weight Penalty is not handled by skill anymore (was producing issues with HP/MP/CP regen).
      - Fix few skills related to HP/MP/CP regen.
   - Physical hit / skill formulas
      - Rework charge skills formula.
      - Rework physical skills formula. Split physical hit and skill formulas. Add a Config.DEVELOPER to track output.
         - Add ssMul 2.04 instead of 2.0 for physical skills.
         - Rework attacker elemental trait usage during regular hit. A physical hit is now considered as "elemental attack" if such trait occurs, raising or decreasing overall damage. Ty Arrowhead for report.
         - Add missing position multiplier for physical hit.
   - Shield rate is now impacted by physical CRITICAL attacks. Add a Config.DEVELOPER upon the associated method.
    - MEN bonus is now only used for isMagic skills. Ty StinkyMadness.
   
Scripts
   - Fix Q501 loyalty check. Ty lucabruns.
   - Add missing Q351 reward. Ty Gigi85 for report and StinkyMadness.
   - Fix Q627 to be party friendly. Ty StinkyMadness for report.
   - Fix Q376 / Q377 onKill logic. Ty StinkyMadness for report.
   - Fix potential CME over Q409. Ty StinkyMadness for report.
   - Flat all uses of Npcs containers using ConcurrentHashMap.newKeySet. Fix NPE over Core script.
   - Rework (rework mechanisms) following quests : Q348, Q403, Q409, Q421 - ty Hasha.
   - Complete (add missing content) following quests : Q114, Q171, Q316 - ty Hasha.
   - Fix (found and fix issues) following quests : Q021, Q609, Q615 - ty Hasha.
   - Replace hardcoded Strings for NpcStringIds over all scripts - ty Hasha.
   - NewbieHelper : Remove uneeded files, fix one link. Ty RooT.
   
Bugfixes
   - Remove Attackable regen task upon active region.
   - Fix FloodProtectors for values > 2147. Ty Gigi85 for report and StinkyMadness.
   - Add charge check over Force Blaster. Ty Gigi85 for report.
   - Fix pet food usage over pet window. Ty StinkyMadness.
   - Fix server-side heading upon unmoving interaction.
   - Fix 8570-8575 items.
   - Avoid to follow yourself. Ty StinkyMadness.
   - Avoid to stop moving upon using skill under cooldown. Ty StinkyMadness.
   - Avoid to stop attacking upon using skill under cooldown. Ty StinkyMadness.
   - Fix the clan/alliance issues upon TargetCorpseAlly / TargetAlly. Ty StinkyMadness.
   - Fix the NPE upon TargetCorpseMob on dead Guard/SiegeGuard. Ty StinkyMadness.
   - Use cast int on double values of HP/MP consuming under canDoCast boolean. Ty StinkyMadness.
   - Update flag pvp status while heal/buff flagged summon. Ty StinkyMadness.
   - Allow the usage of skill on dead target without giving effect. Ty StinkyMadness.
   - Add attacking rules on summons/pets. Ty StinkyMadness.
   - Add "Contract Payment" (Skill ID: 4140) upon Soulless summon. Ty StinkyMadness.
   - Vincenz Blacksmith HTM's (Rune Territory). Ty StinkyMadness.
   - Set 'Lost Buffalo' as minion of 'Frost Buffalo'. Delete individual minions. Ty StinkyMadness.
   - Fix wrong HTM and tokenizer order for observe cost on BroadcastingTower. Ty StinkyMadness.
   - Fix Private Store Buy issues. Ty StinkyMadness.
   - Manor : Reset seed sales. Ty StinkyMadness.
   - Added missing privileges to academy members. Ty StinkyMadness.
   - Normalize all uses of canGiveDamage.
   - Fix few reported HTM typos.
   - Add 32007 npcId missing content (buylist, HTMs). Ty Root.
   - Fix 31616 npcId HTMs and type. Ty RooT.
   - Fix Mortal Strike enchant routes. Ty Sahar.
   
Organization
   - Implement WeightPenalty, ShieldDefense enums.
   - Implement static approach for ExVariationResult failed result.
   - Few SonarLint cleanup.
   - Delete KARMA_PLAYER_CAN_BE_KILLED_IN_PZ config.

L2 OvC Interlude season comes back 1st May !
Added new King's Landing mission.
Added Agathions (appearance only).
Spoilers are now theives again (can steal adena from other players).
Added shadow items with SAs / set bonuses to newbies who join at a later stage of the server.
And much more, see our website for full details.

Changeset 398 (2308)

Admin commands - part II, Petition, TradeList, TargetHandler, Community Manager, Olympiads, Formulas, Bugfixes, Organization

Admin commands - part II
   MovieMaker
      - Fully rewritten, merged under //movie and //sequence. Delete MovieMakerManager.
      - Sequences are stored under TreeMap for automatic sort based on index.
      - Work even if indexes aren't following each other.
      - Sequences parameters are set on individual columns for easier read.
   Delete AdminNpc, AdminCamera, AdminShop admincommandhandlers.
      - Delete //walker, merged with //show (walker).
      - Delete //gmshop, merged with //buy (no params needed).
      - Delete //show_shop, merged with //info (shop).
      - Delete //show_shoplist, replaced by simple //buy.
      - Delete old //camera (redundant with //movie, almost impossible to use)
      - Rename //cameramode > //camera. Fix 2 issues (knownlist is properly refreshed, the camera doesn't bounce back to initial position anymore).
   AdminPetition
      - Merge all admin commands related to petitions to //petition (show, unfollow, reject, join, reset, view).
      - Implement //add_peti_chat and //force_peti from ALT+G panel.
   - //setnoble is merged with //set (noble).
   - Add missing checks for //remove. Ty StinkyMadness for report.
   
Petition
   - Overall cleanup (merge containers, Stream usage, Javadoc, multiple checks added, unhardcode HTMs, improve HTMs details). Rework ChatPetition to avoid to iterate upon sent message.
   - Allow petitions to be saved over server shutdown (lazy save), and properly loaded back (both responders and petitioner receive the Petition window with stored messages).
   - Implement the petition feedback system, and show it upon CLOSED state.
   - You can now add multiple users over a single petition (//add_peti_chat). If such added user "cancels" the petition, he can either cancel it if GM, or simply leaves it if regular user.
   - You can now enforce your target to petition with yourself (//force_peti). It will generate a perfectly regular Petition.
   - Add the possibility to switch from one Petition to another (active petition returns as PENDING if none active GMs are part of responders).
   - You can now move from one Petition to another simply joining another Petition - previous Petition will return as PENDING.
   - You can now unfollow current Petition without having to end it - it will return to PENDING if no left responders are GMs.
   - Set back the Petition as PENDING and remove associated responders if state is IN_PROCESS but no messages were sent.
   - Multiple integrity/sanity checks were added (avoid to reject if already REJECTED, etc).
   
TradeList
   - Add Javadoc.
   - Add missing sysMsg ONCE_THE_TRADE_IS_CONFIRMED_THE_ITEM_CANNOT_BE_MOVED_AGAIN over self-locked TradeList.
   - Add missing sysMsg PRIVATE_STORE_UNDER_WAY over you/partner manage store mode.
   - Add missing sysMsg EXCHANGE_HAS_ENDED over unsuccessful trade - the most common unsuccessful trade being 2 empty validated TradeLists.
   - Fix an exploit moving distance check from trade request to validation. Ty StinkyMadness for report.
   - SendTradeDone packet now uses a static approach.
   
TargetHandler
   - Add noicon over Recover Force.
   - Fix Signets symbols.
   - Delete TargetHandler PET.
   - Fix Treasure Keys.
   - Clear charges over Player death.
   - L2Skill addSummon/addCharacter methods aren't static anymore.
   - Rework canDoCast concept. Introduce ITargetHandler#meetCastConditions for Playable conditions, fixing numerous target issues over cast.
   
Community Manager
   MailBBSManager
      - Move "Mail" class out of it.
      - Don't lazy load mails anymore, everything is done on startup - which avoid to db query to find last mail id.
      - Use PlayerInfoTable to retrieve isGm() instead of db query.
   FavoriteBBSManager
      - Introduce Favorites management (loading, saving, deleting being functional ; proper bypass saving being NOT due to the system chaos - mail coded in a way, memo in another, etc).
   Misc
      - Rename Manager > manager and bb > model packages.
      - Fix NPE over ClanBBSManager access upon clan creation. Ty Gigi85 for report.
      - Add the possibility to close Community Board using static approach (ShowBoard.STATIC_CLOSE).
      - Rename all related SQL tables to "bbs_".
      - Create ForumType, ForumAccess enums. Delete TopicType.
      - Rework the Forum/Topic/Post management and move it from "BBSManager"s to "CommunityBoard". Delete CPost concept. Structure isn't lazy loaded anymore, db connections are far, far lesser.

Olympiads
   - Rename queries, tasks.
   - Remove synchronized, put _nobles as ConcurrentHashMap.
   - Drop _heroesToBe List (no use to retain it), compute it directly on HeroManager#computeNewHeroes.
   - loadNoblesRank() > processRankRewards(), use Entry to iterate data instead of keySet()/get().
   - saveNobleData() "to_save" concept is removed, instead use INSERT ON DUPLICATE KEY. Also use addBatch/executeBatch instead of generating multiple PreparedStatement.
   - Merge few one-shot methods with their calls (scheduleWeeklyChange/addWeeklyPoints, init/updateCompStatus, olympiadEnd/updateMonthlyData).
   - Delete _nobles == null checks (impossible).
   - OlympiadStat doesn't call 4 times the same content anymore.
   
Formulas
   - Hit accuracy calculation : Raise the lowcap from 20% to 30%. Modifiers are now directly applied over acc/eva diff rate (which x2 the impact). Base rate is 90, not 80.
   - Blow damage : fully rework the formula.
   - Blow rate : fully rework the formula.
   - Pdef calculation : Full Armors don't count LEGS bonus anymore.
   - Shield rate versus bows is now x3, out of 30%.
   
Bugfixes
   - Fix pole attack over Players on peace zone. Ty StinkyMadness.
   - Fix CCE over Infinity Axe "Discord" effect. Ty Sahar for report.
   - Rework EffectConfuseMob > EffectDistrust. Only affect Monsters, add a radius check, called only once.
   - Fix 80+ Quests being broken prior to rev 396 Hasha refactor. Ty StinkyMadness for report.
   - Add few missing IdFactory cleanup (bbs_mail<>playerId, bbs_favorite<>playerId, bbs_post<>topicId, bbs_post<>playerId).
   - Don't spend SS over failed Blow. Don't show ATTACK_FAILED message aswell.
   
Organization
   - Add Recovery Scrolls upon //buy "Scrolls" tab. Ty Somename.
   - Implement TeleportMode enum.

Changeset 397 (2224)

Geoengine / Movement, Admin commands, Scripts, Bugfixes, Organization

Geoengine / Movement
   - Drop L2D concept. With years, it got less and less uses (was invalid for LoS, and can be calculated in another mean for geopath). L2OFF and L2J are, anew, fully supported.
   - Fix Z being shifted too high, leading to Z layer misplacement (forts outside wood ladder). Ty Sahar.
   - Fix geopath heuristics. Ty Hasha/Sahar.
   - First iteration of multilayer geopath support (Barakiel column, fort stairs/plateforms, etc) using binary heap. Ty Hasha for the implementation.
   - Fix the 2 IOOBEs related to canSee / canMove (since MoveDirectionType implementation). Ty Hasha.
   - Fix swim movement issue. Ty Sahar.
   - Remove the collision radius offset shrinker in order paths being properly executed (notably visible for Attackable stucking in corners). Introduce back some client<>server desync.
   
Admin commands
   - Addition of AdminCommand model, storing parameters and description of the admin command.
   - Addition of Pagination class, used to easily cut your data and format it under HTMs. Ty StinkyMadness.
   - Addition of multiple useful methods into IAdminCommandHandler to cut some target selection redundancy. Ty StinkyMadness.
   - activeChar > player rename.
   - Delete all admin HTMs related to skills (data/html/admin/skills). Skills list is generated from //skill list.
   - Move previous //help logic to new //link command.
   - //announce without params properly calls the panel.
   - //help is now generated using adminCommands.xml content. Previous static help system is deleted.
   - AdminDoor //open_all and //close_all are deleted (no use).
   - Merge //bkpage with //bk, //knownlist_page with //knownlist. A bookmark name can't be anymore a number.
   - All related server admincommands are merged into //server param.
   - All related siege commands are merged into //siege param castleName.
   - All related castle commands are merged into //castle param castleName.
   - All related zone commands are merged into //zone show "id"|all|clear, //zone calling the panel.
   - All related geoengine commands are merged into //geo.
   - All related pathfind commands are merged into //path.
   - All related skills commands are merged into //skill and //clan_skill. Greatly improve //clan_skill, allowing to add, delete, add all and delete all skills of a Clan.
   - All related summon commands are merged into //summon. Generate AdminSummon out of AdminRideWyvern/AdminEditChar content.
   - All related effect commands are merged into //effect. Merge AdminBuffs with AdminEffects. //effect now handle set, remove and visual parameters. Edit admin panels accordingly.
   - All related item creation commands are merged into //item. Generate AdminItem out of AdminCreateItem. //item coin can accept radius. Drop //reward_all.
   - //info over Player got a new look, added collision radius/height infos over Npc.
   - //runmod is deleted, //instant_move now accepts 0|1|2.
   - //recall_party and //recall_clan are merged into //recall.
   - //goto is deleted, //teleportto is used instead. All "goto" subcommands (ch, cw,...) are also renamed "teleportto".
   - //tele_areas is deleted.
   - //move_to is renamed //teleport. As L2OFF, it can accept only 2 parameters, being X and Y - Z being calculated based on X/Y coords and actual Player Z.
   - //polymorph is now a toggle, merging the 4 previous admincommands to it. Delete the possibility to morph into an Item (too much bugged).
   - //invul and //undying don't work anymore on other targets than yourself.
   - //para becomes a toggle. Delete //para_all and //unpara_all (no use).
   - Delete //special (not existing).
   - Delete all redundant commands ending with "_menu".
   - //abnormal and //social only affect your current target. There is no more player or radius check.
   - //ban, //ban_acc, //ban_char and //ban_chat are all merged. Same for //unban.
   - //kick, //kick_non_gm are merged. //character_disconnect is dropped.
   - Merge //kill, //res, //heal to new AdminManage, which now use [name[radius]] parameters. Delete //res_monster. Delete AdminHeal and AdminRes. //areacancel is renamed //cancel and moved to AdminManage.
   - Merge AdminGm with AdminAdmin. Rename //gm to //gmoff.
   - //ch chId parameter is moved from first to second place (//ch param chId).
   - Delete //cw "info". It is now part of regular //cw, similar to //siege, //zone, //ch...
   - Heal/kill/res/cancel/open/close now accept parameters over //admin quickbox. Added a "Cancel" button upon //admin.
   - Merge //find_character, //find_ip, //find_account and //find_dualbox into //find. //show_characters is renamed //list. Generate AdminFind for it.
   - Delete //clan_info (collide with //pledge info), //st (collide with //effect visual), //get/reset_skills (you can't ninja anymore skills set of another Player).
   - Generate AdminEditChar //remove out of //removereuse and //remove_clan_penalty. Add //remove death_penalty.
   - Drop //forge and AdminForge. Move left //msg to AdminAdmin.
   
Scripts
   - Optional item (e.g. fish) isn't considered as quest item anymore for 3rd class quest. Ty Hasha.
   - Add Medusa and BrekaStronghold AIs. Ty Hasha.
   
Bugfixes
   - Fix 2 NPEs due to AggroList rework. Ty Sahar for report.
   - Fix AttackableAI NPE over thinkIdle. Ty Sahar for report.
   - Fix CreatureCast/CreatureAttack NPEs (definitive edition). Ty Sahar.
   - Fix Doors being non attackable during SiegableHall. Ty Sahar.
   - Fix registration to SiegableHalls. Ty Sahar.
   - Fix Devasted Castle guards. Ty Sahar.
   - Fix BabyPet / Pet skill level. Ty Hasha.
   - Fix RaidPointManager not being properly saved + few optimizations. Ty AshenOne for report.
   - Validate teleport location if a random offset is used. Ty Hasha.
   - Fix invalid PK check over gatekeepers. Ty Dimityr203.
   - Add few more X/Y/Z check validation upons spawns (quest spawns, minion teleport, pet spawn). Ty Hasha.
   - Servitors/pets now spawn heading towards the Player, and their distance is moved from 30 to 40. Both Pets and Servitors use the same spawn rules.
   - Fix Buy shop showing wrong shop quantity. Ty StinkyMadness.
   
Organization
   - FloodProtector is moved to its own enum, on enums folder.
   - Add AggroList#getMostHatedCreature for easier usage.

PS  : Since geoengine doesn't accept anymore L2D format, the exact same geodata is now shared under L2J format. See public sources topic to download it back.