Changeset 383 (1388)

Movement is still experimental. The status IS NOT OK for LIVE servers. Boats and MoveToPawn behavior still need to be fixed.

Movement rework - Part I, Sit / Shop fixes, Safe fall height, Bugfixes, Organization

Movement rework - Part I
   - Fix following issues, plaguing aCis since a while :
      - Clicking fast enough on ground while moving was increasing the distance between the player and its actual real point.
      - Fix the pathfinding issue for monsters, blocking on the first encountered obstacle.
      - Introduce pathfinding for returning to spawn monsters, to avoid they stuck in middle of nowhere or got Z layers issues.
      - Rework most of the offsets to fix issues with move to pawn concept.
   - Introduce a 0.5s delay where player walks instead of run on start of a movement, to fit client animation.
   - Introduce CreatureMove, a complete replacement of MoveData. It's now bound to a Creature, and not generated on every single move. Children exist for PlayerMove and BoatMove. The whole movement logic is moved here (extracted from Character and CharacterAI).
   - Drop MovementTaskManager, every running task is now individual to avoid to register on a clock wall, which means the 100ms granularity is guaranteed without calculations or sync needs.
   - Avoid to process a movement if a movement is already launched with same destination and offset (huge performance boost upon spam pickup action).
   - Add a debug for movement system using ExServerPrimitive packet. It offers a good sight of what happens during movement process.
   
Sit / Shop fixes
   - sit/stand is now backed by _sitTask, to track delay between sit and stand position.
   - shop stand up is now instant to fit with retail and avoid exploits.
   - Player#canOpenPrivateStore is now used on 2 different places (shop opening and validation) and handle more checks. Fix multiple issues/exploits, like being able to shop while being mounted.
   - StoreType is renamed OperateType, and now include missing MANUFACTURE_MANAGE and OBSERVER. All getters/setters are edited.
   - MANUFACTURE_MANAGE is implemented, it's not possible anymore to open both (buy or sell) and manufacture panels.
   - All buy/sell/manufacture player lists are now generated on Player creation (no more lazy initializations / container creation, no more null checks).
   - Improve Player#instantStandUp(boolean) a little (don't bother with stand up if already stand up).
   - Add NO_RECIPES_REGISTERED check upon MANUFACTURE_MANAGE ; call the empty window. Add ManufactureList#_isDwarven, which allow us to call back previous state without error.
   - Don't set OperateType.NONE on invalid item count for both sell/buy manage (was leading to invalid store state). Add retail messages.
   - Fix the fact you aren't supposed to open a shop when already sat.
   - Fix the buy/sell/manufacture tryOpen methods : Don't bother with manage case, and tryOpenWorkshop only care with right OperateTypes.
   - isInStoreMode() is modified to only returns real cases of store mode. Manage cases aren't part of it.
   
Safe fall height
   - Added retail values based on classes and sex (was semi-implemented core side using default value 333). Ty RooT for dp side.
   - Add CANNOT_DISMOUNT_FROM_ELEVATION wyvern check, making it impossible to dismount a wyvern if not in a valid safe fall height.
   
Bugfixes
   - Fix Q009 reward itemId. Ty p0w3rf1y.
   - Fix Q621 / Q622 haste potion itemId reward. Q621 giveItems recipe instead of rewardItems. Ty Idontknow1.
   - Add retail behavior regarding teleporting to nearest town if wyvern feed task ends.
   - Seeds works anew (was due to invalid handler name on XML).
   - Edit few mercenary tickets SystemMessage to use retail ones. Ty RooT.
   - Fix the delay for mass teleporter (no instant case if out of siege). Ty RooT.
   - Fix Baium zone (around door, to avoid teleport back to town) using L2OFF GF values, IL being buggy.
   - Fix the few cases of mispelling or miss on configs properties files.
   - Fix radius/height/level/stats of all NPCs, except summons and tamed beasts. Ty StinkyMadness.
   - Add few missing Manor Managers on relatedNpcIds (was leading to NPEs).
   - Fix a MinionList NPE, prior to minions rework.
   - Add few missing Seven Signs event sounds. Ty RooT.
   - Drop calcFestivalRegenModifier system, which was leading to negative values and isn't retail. The only affected stat is MP regen, and it's positive, based on MotherTree zones.
   - RaidBossManager#cleanUp fix prior rev 382 edit.
   - Fix multiple SpotBugs reports (18 or so), from invalid equals/hashCode contracts to missing switch break.
   - Fix RequestListPartyMatchingWaitingRoom, RequestAskJoinPartyRoom : variables aren't set as static anymore.
   - Fix the client crash when clicking "projection" button on the "record of seven signs" (introduced on rev 239).
   - Upon SA activation on magic use, S1_HAS_BEEN_ACTIVATED message is now working and called BEFORE resist attempt.
   - FleeingNPCs / 4s victim scripts flee behavior are enhanced.
   - AI is correctly flushed upon IDLE case, leading to proper global aggro value reset (10sec aggro cooldown on respawn).
   - Fix party duel CANCELED state for ZoneId.PVP.
   - Boat _passengers is now concurrent to avoid CME.
   
Organization
   - Move _isNoRndWalk from Creature to Attackable, _isChampion from Creature to Monster.
   - Slight edit of Creature#isInsidePeaceZone (no static, first param is self).
   - Rework WorldRegion#setActive, it now uses an AtomicBoolean. Add WorldObject onActiveRegion() / onInactiveRegion(). Behavior is normally exactly the same than old setActive, but cleaned up.
   - AttackableAI#changeIntention getKnownType(Player) check is now replaced for getRegion().isActive(), probably leading to a lot of saved garbage. SiegeGuardAI#changeIntention override is dropped.
   - Remove GeoEngine.getInstance().canMoveToTarget pre-optimizations (it's already handled by moveToLocation).
   - Add missing onEvtAfraid and AFRAID AiEventType use. Rework Fear effect to use it.
   - Merge Instance#doPickupItem(WorldObject object) with AI#thinkPickUp() (single use).
   - Add Location#equals(int x, int y, int z), Location#setUsingPositiveOffset, Location#setUsingRandomOffset and Location#setFleeing methods.
   - Addition of StatsSet#getIntIntHolderArray.
   - ItemTable cleanup (renamed ItemData and moved to data.xml, CLogger, move temporary containers to good place, move _slots Map to Item, javadoc).
   - Item cleanup (drop Logger, correct use of StatsSet methods to feed Item values, javadoc)
   - Rework both Weapon#getSkillEffects (Fix the multiple calls upon getSkill() and getFirstEffect, rename those methods castSkillOnCrit / castSkillOnMagic for easier understanding).
   - Fix one strange use of StatsSet upon FestivalOfDarknessManager.
   - Rename all items handlers to keep naming convention logic.
   - Add warning regarding missing property key on configs. Ty StinkyMadness.
   - Add UseBlowfishCipher config. Limit the byte array size on VersionCheck packet. Ty RooT.
   - Drop few skills parameters duplicates, ty bowling4soup.
   - Addition of RaidBossManager#getBossSpawns() and BossSpawn#toString for easier customs implementation.
   - Numerous packet reorganization :
      - Few packets rename to fit NetPro.
      - "activeChar" naming is replaced for "player". Final keywords added here and there. Variables naming is more friendly and/or conventional.
      - NewCharacterSuccess uses a static approach for now.
      - Deletion of SuperCmdCharacterInfo, SuperCmdServerStatus && SuperCmdSummonCmd packets (custom, unused).
      - Implement SendTimeCheck / RequestTimeCheck packets. Ty RooT.
   - AdminCommands
      - Delete AdminMammon and associated admincommands.
      - Merge all cursed weapons admincommands into //cw.
      - Cleanup //admin2 panel (game_menu.htm).
      - Delete //adminX commands. It is now simply //admin. //admin can now answer to file names (ex. //admin server).
      
PS : all items XML etcitem_type parameters are edited to reflect enum value (use of caps lock).

Movement is still experimental. The status IS NOT OK for LIVE servers. Boats and MoveToPawn behavior still need to be fixed.

New season starts 9 August.
Made many balance improvements, added new Daily Quests system and a new Hybrid map: Anakim VS Lilith Arena.
Don't miss it !

New season coming, begins on August 10, 2019 at 6PM. (UTC -3)
Server information updated in the first post. 

GitHub migration

I inform you than both public and private SVN repositories moved to GitHub. Since Eclipse got default GIT integration, it's normally easier to parameter it.

GitHub offers collaborative tools. You can easily fork public sources and share your contributions (called pull request). Source owner can then decide to accept them or not, which make them accessible to anyone in return.

aCis private repository is still hidden. Rules aren't modified, but will maybe evolve for customers, since diff patch system seems hard to be done.

SVN repositories won't be updated from now on.

MariaDB with HeidiSQL

Download and install MariaDB from https://downloads.mariadb.org/. I recommend to always install latest stable version. Please note than MariaDB and MySQL share the same writting style, so the revert is possible if you want (but we don't support it).

HeidiSQL is included into MariaDB package. It is a free replacement of Navicat SQL and allow you to modify your database.

---

JDK 8 / 11 / 21

Download JDK depending of your sources revision :

• < 381 : JDK 8
• > 381 to 406 : JDK 11
• > 406 : JDK 21

Pick it from either openJDK or Java :

• https://adoptopenjdk.net/
• https://www.oracle.com/fr/java/technologies/downloads/

QuoteIf you downloaded the installer from AdoptOpenJDK site, you can skip this step, as the installer adds the Java path itself.

Follow it only if you downloaded OpenJDK / Oracle / archive version as it requires manual edits.

You must add Java path to the system environments when using JDK 11. Java 8 automatically adds it to the path, so for free sources skip this part.

Right click on your Computer > Properties > Advanced system settings > Environment variables, select the Path variable and click Edit button > and then set the path to your JDK installation.

---

Eclipse IDE

Download latest Eclipse IDE from https://www.eclipse.org/downloads/packages/. It does not really matter which version you choose, but Eclipse IDE for Java Developers is enough and got all standard Java tools.

---

Importing the project from shared sources - customer case

---

Importing the project from GitHub

---

Project compilation and configuration

---

Updating server

After some personal edits, you will need to do following :

• If you edited core side : compile the pack, pick l2jserver.jar library and copy/paste it in the libs folder of your loginserver/gameserver, depending what you edited.
• If you edited datapack : replace whatever you edited.

---

Preparing the client

Over http://anothercrappyinterludeserver.com/files/, you will find following content :

• InterludeUpdate071212Full.7z : The latest IL patch, to apply to raw client.
• Lineage_II_Interlude_p746_win10_071212.rar : The raw client + latest IL patch + system folder patched.
• System 746 - Patched exe, dat, nogg, nosleep.rar : the system folder patched.
• engine.dll : A DLL to add if your system crashes at startup.
• lineage2_interlude_client.7z : The basic, unedited client.

New Interlude season starts 31/05 !
* Real money achievements system.
* Improved castle siege system.
* NO donation for gear.
* New mission: The White Walkers.
* New mini event: Multi TvT (4 factions).
* Twitch stream rewards.

http://l2ovc.com

And for Game of Thrones fans, special mission 

On 2019-04-30 from 10:00 till 13:00 (GMT +3) we will perform a planed maintenance. Due to this reason, our services / websites will be temporary down.

Scheduled Maintenance on 2019-04-23 12:00:00 
Estimated finish 2019-04-23 13:00:00