Changeset 392 (1847)

ExServerPrimitive, GeoEngine, Movement, Friend/BlockList, Enchant / Paperdoll

ExServerPrimitive
   - Color is now defined only via Color, rather than int. Extra methods are dropped.
   - Added addSquare, addRectangle methods for easier draw concepts.
   - Updated AdminGeoEngine "can_see" command graphics.

GeoEngine - ty Hasha.
   - Updated canSee, canMove and getValidLocation methods.
      - Now using exact line of sight/movement and checks all cells in the way, rather than using LoS/LoM approximation using Bresenham's line algorithm (see https://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm ).
      - Computation more heavy per each iteration. Performs approx 25% more iterations per path (25% more geodata cells evaluated). Still worth the accuracy.
   - Fix LoM check giving false positive result, when target is on "balcony".
   - Added first iteration of canFloat check, can be used for both, flying and swimming. Though the movement itself should handle all special cases (like water level, when swimming from bottom up).
   - Added new admin command "geo_fly" to check LoF.
   - Misc.
   
Movement
   - Rework moveToPawn / moveToLocation concept, for both Creatures and Players.
   - Introduce ValidatePosition debug (part of //show move) to visually see server<>client desync. Rework ValidatePosition.
   - Fix most of server<>client desync.
   - Fix dead/teleporting/disconnected over target follow.
   
Friend/BlockList systems rework - ty RooT.
   - Add missing packets and make a correct use of it.
   - Delete //silence && //tradeoff admincommands.
   - Move isBlockingAll concept to BlockList. Basic BlockList cleanup.
   - Add missing blocklist check over clan invitation.
   
Enchant / Paperdoll rework - ty RooT.
   - Drop all admin commands from AdminEnchant except "admin_enchant".
   - Drop enchant.htm, use quickbox instead.
   - //enchant doesn't work if the same enchant is already set.
   - Introduce Paperdoll enum. Rework most methods to use it.
   - Big cleanup of Inventory. Move some overriden behaviors back to PcInventory. Add Javadoc. Move ChangeRecorder out and rename it ChangeRecorderListener.
   
Organization
   - Delete unused configs : INVENTORY_MAXIMUM_QUEST_ITEMS / DEBUG_PATH / LOG_LOGIN_CONTROLLER.
   - Delete 2 unused ItemInstance variables.
   - Few unused methods deletion over SendablePacket.
   - Move ItemLocation and ItemState to gameserver.enums.items.
   - XCast/XMove/XAttack now use generics, _creature is renamed _actor and now uses proper instance type which avoid cast.
   
Bugfixes
   - Introduce back NPC castle guards. It will be kept like this until SpawnManager introduction.
   - Fix NPE related to castle guards / mercenaries Castle attribution.
   - Fix ControlTower castle guards spawns cleanup over doDie.
   - Fix NumberOutOfRange exception over hero fight loading. Ty BIGMANF.
   - Fix GMViewWarehouseWithdrawList packet. Ty StinkyMadness.
   - Fix Blacksmith Rooney spawn time. Ty vampir.

Changeset 391 (1815)

Rev 390 bugfixes, Cubics part II, MailBBS, Geoengine, Skills, Organization, Bugfixes

Rev 390 bugfixes
   - Fix Guards / FriendlyMonster which don't see chaotic pets/summons. Ty shyr for report.
   - Summons can properly attack FriendlyMonster. Ty shyr for report.
   - Fix Summon follow stackoverflow.
   - Drop GM onAction shift behaviour, which automatically fixes missing ActionFailed issues (= stuck) over multiple shift uses.
   - Fix Non-Playable not being attackable in Peace Zones. Ty shyr for report.
   - Fix SummonItems cast process. Don't consume flute anymore. Ty shyr for report.
   - Item consumption is fixed (checked on canDoCast, done on doCast).
   - Remove USE_S1 message over item skill usage. Only item usage message should be sent.
   - Fix CreatureCast#onMagicHitTimer/onMagicFinalizer NPE. Ty shyr / xTakegawa for report.
   - Fix missing ActionFailed mackets over INTERACT/FOLLOW. Ty shyr for report.
   - Fix attackable states for ControlTower, Door, FlameTower.
   - Proper HP/MP checks over CreatureCast#canDoCast.
   - Fix invalid interact radius. Ty shyr for report.
   
Cubics part II
   - Add a 2s cast task (tested on L2OFF for at least 3/8 cubics, I suppose other do the same). Ty shyr for report.
   - All fireAction() submethods are cleaned up.
   - Implement CubicList, a Player related container.
   
MailBBS
   - Fix error upon sending mail. Ty Marcatu for the fix.
   - Move MailType to enums package.
   - Various optimizations + 2 potential NPE fixes.
   - Subject overview is limited to 30 chars to avoid layout deformation.
   
Geoengine
   - Fix double-layer issue, creature must follow the upper layer.
   
Skills
   - Fix Pig Chest skillId 2309. Ty RooT.
   - Fix 4624 skillId. Ty Vonak.
   - Fix effect power for 4 "chance" enchant routes. Ty xblx.
   - Add missing ItemSkills handler for Rice Cake. Ty shyr for report.
   
Organization
   - Implementation of //info, merging GM onAction shift content (summons, players, doors, npcs, statics objects), //summon_info and //npcinfo. The idea is to keep consistancy between GM and regular user behaviours.
   - Introduce Siege#announceToPlayers(SystemMessageId).
   - Rework Clan notice/introduction handling.
   - Add StringUtil#trim method, allowing elegant one-liner over String truncates handling.
   
Bugfixes
   - Titles are now properly showing 16 chars, not 15.
   - Fix missing Clan buttons over character restart. Ty djwegas.
   - Add sps/bsps consumption upon Cubic/Servitor summon process.
   - SiegeFlag are now immune to Swoop Cannon damages. The task is now backed by a Future for doDie / deleteMe cases.
   - Drop FestivalMonster#isAttackableBy override (no specific mean).
   - Doors can now be damaged by regular skills. Walls are still not attackable by anything except SiegeSummon. Swoop Cannon can't target or inflict damages to doors/walls.
   - Fix orc mystic stat calculation. Ty Hasha.
   - Fix Admin teleport (Pirate Tunnel). Ty shyr for report.
   - Fix 3 HTM typos. Ty An4rchy for report.
   - Fix isMortal() concept ; limit the HP drop to 1 and not 0.
   - Properly set Attackable aggro over Summon doDie.

Added tag system over Bugs report section, to make things clear. Ty Sido ! 

- "Public Workbench" board is dropped, since it wasn't used as it should be. All shares are moved to "Shares" board.
- All subboards of "Bugs report" are dropped, and content merged with "Bugs report" section. It will be eventually replaced by a tag system.
- Add a subboard "Transitional Crap" on "Bugs report". It reflects the current progress of Bugs report resolution for next revision. When a revision is reached, the whole content is moved to Archives, as it was before.

Public sources have been pushed to 382.

I voluntarily set 382 and not 380, to give you the best experience possible, as currently both latest (390) and 382 share OpenJDK 11.

That will avoid you to play with JDK versions.

Changeset 390 (1785)

Ai system rework - part II, Movement - part II, Geoengine, Debug, Cubic system rework, Admincommands, Skills, RecipeBook, Organization, Bugfixes

Ai system rework - part II - ty bowling4soup
   - Fix following issues introduced in previous revision :
      - Cast on too far target block other actions.
      - Fix INTERACT behavior, when already near the target (case of shops, for exemple).
      - Fix randomly stopping attack action when using poles.
      - Move updatePvpStatus from doAttack to onHitTimer (in order pvp flag occurs when the hits occurs).
      - Fix a problem when pushing sell/buy button while being already under animation effect.
   - Fix SummonItem cast, generating SummonCreature skillhandler - cast of such items can now be properly interrupted.
   - Add ATTACK intention for nextActionIsAttack() skills, even if skill failed.
   - Fix an issue over RequestTargetCanceld, rename it to RequestTargetCancel.
   - Few tasks (effects, hp/mp regen, decay) are now properly disabled over deleteMe().
   - Add missing ActionFailed uses over thinkPickUp checks. Ty Djwegas for report.
   - Rework most of INTERACT behavior (onAction / onActionShift).
   
Attack / Cast - ty bowling4soup
   - Rework entirely both processes :
      - Moved all the checks out of doAttack, doCast. Generate canAttemptCast, canDoCast out of it. Implemented hierarchy.
      - Reorganized getTargetList so that targets are only calculated once during onMagicSkillLaunched.
      - Generate doToggleCast, doInstantCast, doFusionCasttimeCast to avoid to use regular cast process.
   - Toggle skills properly stops the Player. Message is sent for both activation/desactivation.
   - Add missing CHARGEDAM over L2Skill#isDamage() - those skills can now be used as part of CTRL key.
   - All methods related to isAttackableBy / isAttackableWithoutForceBy are now verified using L2OFF.
   
Movement - part II
   - Creatures (players excluded) don't use moveToPawn as follow state anymore. Ty shyr for report.
   - Summons' summon offsets are now secured, and retail-like (8 possible locations).
   - Fix the desynchronization between multiple direction switch. Ty bowling4soup.
   
Geoengine - ty Hasha
   Geoengine
      - Fix GeoEngine#canSee must succeed, if all iterated points pass checks.
      - Dropped all "getXXXOriginal" methods.
      - Updated LoS to new logic, dropped redundant methods. Now applicable to all IGeoObjects as targets, not only Doors.
      - Renamed "canSeeTarget(WorldObject, Location)" to "canSeeLocation" to prevent misplacing, it has different LoS mechanism.
      - Fix getValidLocation(), which was enforcing geo position, even if tested position was good (item drop position, etc).
      - Javadoc, cleanup.
   ABlock
      - Dropped all "getXXXOriginal" methods.
      - Updated all methods with IGeoObject - target to be ignored.
      - Javadoc, comments update.
      - Dropped all "getXXXAbove/Below" methods, we access these data via "getIndexAbove/Below" and "getHeight(index)"

Debug - ty Hasha
   - Zones now use ExServerPrimitive for visual show.
   - Add a Player pool of ExServerPrimitive packets for debug usage. Multiple debug can coexist.
   - ExServerPrimitive are chained when max capacity is reached, to avoid client crash/lag.

Cubic system rework
   - Big cleanup over related files.
   - Life cubic activation rate is now affected by a %, based on friendly target's percent HP loss.
   - Life cubics don't heal anymore summons (part of CT1 patch note).
   - First activation time is now delayed, and not instant anymore.
   - Summoning an already summoned Cubic now refreshes the timer of already existing Cubic, and don't summon another Cubic.
   - Summoning a Cubic while being filled up replace the proper Cubic (aka, the first summoned on the queue).
   
Admincommands
   - Delete following commands : addlevel, edit_character, current_player, char_manage, teleport_character_to_menu, add_exp_sp_to_character, add_exp_sp, remove_exp_sp, setkarma, setrec, settitle, setname, setsex, setcolor, settcolor, setclass, setlevel.
   - Add //set command, which merge following commands : access, karma, rec, title, name, sex, color, tcolor, class, level, exp, sp. 2 admin panels are dropped, due to //set implementation.
   - Add //test command, which is a blank command used for any type of developement purpose.
   - Add //show (clear|move|path) admincommand. You're now able to see movement of any character (player/monster).
   
Skills
   - Implement AURA_CORPSE_MOB SkillTargetType, used by Festive Sweeper.
   - Add missing stats on Zealot. Ty babuin.ua.
   - Add missing ssBoost info on Whirlwind. Ty p0w3rf1y.
   - Edit power of Wild Cannon. Ty p0w3rf1y.
   - Shield Slam duration edited from 2min to 1min. Ty xblx.
   - Drop BEHIND_AREA SkillTargetType (unused).

RecipeBook
   - Add RecipeBook container, handling all recipe processes.
   - Recipes are now saved/deleted on add/remove, not on Player disconnection. Ty Reynald0 for the idea.

Organization
   - Cleanup "Change Subclass - Action" redundant behaviors. Slight edit on Player#setActiveClass.
   - Edit all offset related methods from Location/SpawnLocation. Ty Hasha for help.
   - ItemInstance#dropMe is reworked.
   - Earthquake packet is reworked. Add missing isNpc parameter, ty RooT.
   - Put .gitignore rule about log folder.

Bugfixes
   - FloodProtectors class now uses a nano approach, instead of ms. Add MoveTime FP.
   - Fix Player#disarmWeapon. Ty Djwegas.
   - Add checks over buy/sell/manufacture processes to avoid packet crafting.
   - Remove whisper check about equal receiver<>emitter.
   - Add missing Antharas Earthquake effect, put retail values for Dimensional Rift.
   - Fix scenario where FREIGHT items are stuck on the ground after dropping them. Ty p0w3rf1y.
   - Implement missing AcquireSkillDone serverpacket.
   - More Location#clone() usages.
   - Shout, trade and all chat aren't blocked by Blocklist anymore.
   - Fix all int overflow issues. Ty HeeroYuy.
   - A shop can't be set if pvp flag is currently occuring.
   - An item buy/sell can't occur if either the shop or the buyer/seller is dead.
   - Fix few wrong SystemMessage :
      - Evaluate on null target.
      - Trade request on null target.
      - Few retail SystemMessages instead of custom.

The best of the Latin community is back.
Warn your friends, challenge your enemies and come make history, as this is our legacy!
www.l2free.org

OPEN BETA
April 5, 2020 at 12:00

Our BETA will start on April 5th at 12:00 pm.
It will be 2 days for you to know the characteristics of the server and prepare for our grand opening.
Any questions we will be available in our: Email, Facebook and Forum.

New season coming, begins on April 12, 2020 at 12:00. Server Timezone (UTC-3)
Server information updated in the first post. 
L2Free.org