Last aCis updates

[Tryskell]

I decided to let anyone check detailed version of that topic, like that eventual testers can test things more accurately. I'm a whore, but not a sadist.

Changeset 215

Olympiads (part I), misc

Olympiads

Well that was kinda long and I'm fed up to test all again and again (tri-boxing). Part I will be followed in future by part II when/if problems are found. For the moment, I know one "major issue": one of player (the second registering so far) see his own HP bar instead of enemy's.

The implementation is supposed to be FINAL. Report anything which isn't retail-like in order I correct it. If you're Inner circle member you got access to my notes about Olympiads. So consider to use them, and try to find infos on others websites if you think something is wrong.

So here is a mini list of features :
- Freya Olympiads downgraded to IL, including damage amount count (summons too), retail uses of olympiad zones, improved timing system, pretty organization splitting.
- retail olympiads observation system, with updated state (in progress, counting time, terminated,...)
- heroes diaries and hero message (@Monument of Heroes).
- retail items usage (firecrackers / echoes crystals / energy stones allowed - addition of isOlyAllowedItem() -, autosoulshot/manual BSS are forgiven).
- retail Hero pickup at the Monument (leeched from Sigmo, which leeched from another pack surely).
- reorganization of admin commands based on Olympiads in a particular handler, AdminOlympiad. Some commands are refactored (setnoble, sethero) to be far lighter.

Misc

- the pet's name on summon item is now updated when you choose a pet's name.
- improvement about clientStartAutoAttack (when your summon hits an enemy, you're in attack stance ; now it sends far lesser packets)
- more uses of getActingPlayer().
- logout packet doesn't update items anymore. It seems it wasn't needed at all (even crashing client, that was saving amounts).
- IdFactory deletes many more infos if character was previously deleted (so better cleanup is made).
- addition of dropAllSummons() in L2PcInstance - do as the name says.
- correction of a couple of SystemMessageId (hi5 => back to IL).
- fix the problem with sendPacket(SystemMessageId) from L2PcInstance.
- L2SkillTeleport cleanup.

[Tryskell]

Changeset 216

4 quests, many misc. Ty to FighterBoss, Sikken, EnDmOsT, dEvilKinG, Vhalior && SweeTs.

4 quests
   - addition of Q296, Q636, Q640 && Q659.

Misc

   - Fix many skill reuses and hitTime to follow L2OFF. Some skills are more balanced, and globally classes which suck, suck less.
   - Corrected 2-3 HTMs typos.
   - Fix some items (Potion of Revenge && Endeavor potion, Shining Bow reuse delay,...).
   - Unhardcoded Olympiads item restriction. Drop of the previously added isOlyAllowed system, to use "is_oly_restricted", added long time ago by DiNoR. Understand now any item can be used on Olympiads, but is limited by "is_oly_restricted" when setted to True. If you find an item with/without that check when he should haven't/have it, consider to share diff patch about it. The related config is dropped.
   - Added "Blessed spiritshot for pets" in the restriction list, aswell as the autoactivation. Removed Star Shard (elven firework) from restrictions.
   - Fix Pagan Teleporter about Faded item.
   - Fix Linux DB installer (missing from previous commit). Ty DarthVader to pointing it.

[Tryskell]

Changeset 217

Addition of 6 quests.

Q264, Q338, Q356, Q621, Q649 && Q651. Ty to sharers.
HTM typo fix, ty vl4d to pointing it.

[Tryskell]

Changeset 218

Pets big update, accessories debug, little npc.sql update.

Okay, that's it. I'm first sorry for the delay. I was taking a little break trying GoD on EU server (btw my name is Tryskell, /friendinvite me if you see me ingame). I reroll a lot to make a lot of money, enjoy the free exploit...

Second, the update is quite "big", even if it's not really awesome. I had to check many things about pets, because they were entirely messed up. I hope the biggest part, if not all bugs, are now corrected. I tested almost all possiblities (force delog, etc) and all seems fine.

I had to check aswell the npc.sql Darth sent me. After a couple of checks I had to ask to Darth to split data in 2, because it was really messy (collision system is a little stupid in L2J...).



Pets updates.
   - fully fix pet weapons and armors equip, and "race" condition (hatchling/wolf/blabla). I decided to keep the old system as it was really easy to understand it. The core changes automatically the bodypart for "chest" or "r-hand" following type of item.
   - addition of a feature (dunno if it's custom, and don't report because it won't be changed) : if you right click on a pet weapon/armor from YOUR inventory, it automatically TRANSFER && EQUIPS it to your pet's inventory if you got a pet summoned. Previous equipped item is desequipped and stays on pet's inventory..
   - fully fixed stats modifiers of summons (seriously it was a pure mess, many buffs just did nothing before, pets had 0 accu/evasion).
   - decreased amount of packets sent compared to current L2J (-1 packet per 10sec, and that fix too a minor bug targeting pet window every 10 sec)
   - off-like (if not retail) transfer system at unsummoning pets. Ty SweeTs for the report. Inventories of pets are cleaned at delog/unsummon, transfered to your. There is no check about slots/weight, as it is used for DELOG (and imagine at delog that don't transfer, you lose items ).
   - fix RequestPetUseItem behavior. Now only one itemhandler is readed (using a pet food you had twice the code readed before o_o).
   
Misc
   - fix the mythic accessory bug aCis got since 100+ revs (about 2 slots accessories). Now all is fine. Enjoy Wizard's Hat.
   - when you pickup arrows and it fits with your bow and you are arrowless, arrows are now automatically equipped. Ty bomj for report.
   - improvement of npc.sql, with the addition of retail decay system. Now all mobs got their particular timer. It debugs mobs like Gigantic Chaos Golem. Only L2Attackable are concerned, as they are the only ones supposed to die. Others use the hardcoded in core as a default, which is 7 secs (still, the sql is correctly filled anyway). Addition of all missing weapons (some can still be wrong, but it should fill a lot of templates).
   - a couple of NPE fixes (itemhandlers).

[Tryskell]

Changeset 219

MASSIVE UPDATE - YOU NEED TO USE JDK 7 FROM NOW.


Well it's a really huge update. JDK 7 is now needed. Ty xblx for the libs update.

GENERAL
   - Updates of all existing libs, leading to heavy changes (mainly Trove-based codes).
   - Update of base64 code.
   - Update of internal Java-engine (scripts engine) which needs JDK 7.
   - build.xml will now check if you use JDK 7 or no. If no, build will fail, and an error message will invite you to dl latest JDK.
   - Addition of L2TIntObjectHashMap on util.
   
NCPS RELATED
   - NpcTable code is fully reworked, utilitary "getters" aswell. More infos on GS start aswell.
   - update of npcskills (ty to old DiNoR rework), using L2OFF values. Changes are huge and correct known issues (ex : Prismeval island) :
      - active skills => from 15894 skills, it now loads 20844 skills.
      - passive skills => 7k~ skills added.
   - L2NpcTemplate values are now private. Creation and use of "getters". Addition of isType("").
   - Aggro value is now loaded from AI (instead of npc.sql). All aggro ranges > 1 and < 500 have been changed for 500.
   - Sieges guards AI has been updated.
   - overhit flag is reseted when the L2Attackable dies.
   - creation of _staticAIData on L2Npc, which avoids to refer to template each time.
   
PETS && SUMMONS RELATED   
   - Baby pets are fully reworked (addition of conditions such as mp consumption, pet mental behavior (betrayed, blabla), etc).
   - Tamed beasts got a little update, as getSkillsArray() exist now.
   - Levels of pets skills are now correctly calculated. It can use lvl 1-12 skills levels following pet level.
   - fix an issue about items consumption @ SiegeSummon, leading to "ghosts" summons. Ty xblx for fix.
   - if you try to use a skill than a summon should have but haven't, it shows you the missing skillId to add on npcskills.
   - When you try to use a pet skill but difference of lvl is > 20, you can't control the pet.
   
MISC
   - Harvest/Sow skillhandlers are reworked, and Seed system too.
   - addition of _skillMaxLevel in SkillTable, preloading max level of skills in a map for future uses (before it was made on the fly).
   - orc mages are now considered as mages, not as fighters anymore (should fix the SpellForce issue).
   - fix Orfen messages for retail ones.
   - Correction of a couple of items. Ty SweeTs for patch, it is *untested* but should work at first look.


I'm aware there's an issue about pets. HP/MP are not working as intented (not readed from PetDataTable). It leads to problems like a lvl 15 wolf got same HPs than a lvl 55 one, or a pet can't use properly a skill because asked MP consumption for skill use is higher than maxMP. Others stats are correctly working.

[Tryskell]

Changeset 220

Pets update, misc.

Ty to all contributors - Sikken, xblx, Junior, MC.

Pets are now normally fixed.
   - when a pet raises level, his stats and HP/MP infos are corrected shown.
   - Fix an issue when you give a name to your pet.
   - Pet control item is now correctly updated, both on name update and pet level raising.
   
Misc
   - Fix 4 skills.
   - Addition of Life Stones in GM shop.
   - Monastery AI sends now only one type of chat, but it is retail-like (better 1 retail than 3 customs).
   - fix 2 teleports location - untested.
   - Addition of a check to see if entered id is a valid NPC template for //polymorph. In addition, you can't transform if you're already mounted.
   - Fix an unvalid SystemMessage.

[Tryskell]

Changeset 221

Misc

- Addition of missing skills for 3rd class summons.
- Fix //polyself, adding check on templates.
- Remove the useless button "Diet" on admin panel.
- Addition of Ketra/Varka support. Ty fernandopm/Kenrix for their work.
- Correct some things on " chat (GMs aren't blocked anymore), and send systemMessage when possible.
- porta skill (GetPlayer) is now retail-like.
- Fix an issue about BossZone (L2Summon != L2SummonInstance)
- Avoid to stuck client if you try to exploit augment panel (trying to drop weapon/gemstones/LS).

[Tryskell]

Changeset 222

Quests and misc
   - Addition of Q350, Q618, Q645 && Q646. Ty to sharers.
   - Fix the systemMessage about double summon.
   - Addition of a systemMessage when pet pickups a full item.
   - eventual fix of a NPE.

[Tryskell]

Changeset 223

Addition of 7 quests - ty to sharers.

• Addition of Q104, Q257, Q331, Q351, Q431, Q623 && Q644.
  
• Fix a couple of typos and rewards on Q105.
  
  
  
  Changeset 224
  
  isMagic / staticReuse, typos.
  
  
• Fixed hundreds of skills using L2OFF infos about isMagic / staticReuse system. Ty dEvilKinG for the good job.
  
• Typos for classes folder. Nothing special.
  
  
  
  Changeset 225
  
  Raid bosses minions update.
  
  Ty to 100500 for his detailed work.

[Tryskell]

Changeset 226

Quests and minor fixes - ty to the numerous contributors.

Quests
   - addition of Q298, Q317, Q368, Q370 && Q432;
   - fix a couple of existing quests (correct solo => party quest statut, and deletion of useless checks).
   
Fixes
   - addition of a missing NPC spawn.
   - correction of an HTM.
   - 2 items fixed.
   
I must apologize about current project's progression. I played a lot those days.
I got an Othel rogue lvl 86 40% (with 3 subclasses, 75 HE / 75 ES / 65 Pal) on Core server, so don't search where was gone my time...

[Tryskell]

Changeset 227

Addition of 8 quests, ty to all sharers.
   - Q124, Q299, Q300, Q328, Q352, Q353, Q355 && Q366.
   
TO SHARERS :
   - If you made one of those quests, please READ and ANALYZE the differences between your old share (they are kept in Archives section, you normally got access) and the current rewrite. From looking differences, you can learn what I dislike as typo, what, why and how I corrected.
   - I would like to repeat, as Inner Circle you got access to some internal infos, such as L2OFF HTMs. Use it !
   - And ofc, read a walkthrough of concerned quest when you code the quest. The reward formula is one thing, the complete walkthrough is another !

[Tryskell]

Changeset 228

AbstractNpcInfo, polymorph, summons/pets, quests, misc.

Implementation of AbstractNpcInfo
   - SummonInfo, PolyInfo and NpcInfo share the same Abstract layer.
   - CharInfo code about polymorph is cleaned. All is made with knownlist.
   - Addition of a config to on/off NPC crests (when a clan own castle linked to a town). Ty SweeTs for inspiration.
   
Polymorph
   - drop of 3 admincommands (polyself).
   - polymorph commands work by default on yourself if no target is found.
   - addition of success messages on command uses.
   
Summons / pets
   - Addition of a config to on/off owner's clan crest on summons.
   - Fix titles : summons (blue color) and pets (green color).
   - Fix team circle (duel), karma and pvp flag (summons color name, based on owner's).
   
Misc
   - Addition of broadcastNpcSay(String) in L2Npc, and fix all uses for that new method.
   - Drop of setKarmaFlag(int) and broadcastTitleInfo().
   - Addition of 2 quests (2/5 FoD quests made) : Q021 && Q022.
   - Addition of retail chat windows for Mysterious Wizard (located near spawn of FoD).
   - Addition of minions infos for 2 mobs in FoD.
   - L2CharTemplate rework (private variables, public getters).
   

[Tryskell]

Changeset 229

Henna rework, ty xblx for the good work.
   - XMLization of hennas ; 3 SQLs are dropped and their infos are written in a unique file : henna.xml.
   - fix an issue with Human Mage class (class nÂÃ,°10), which could wear dyes - but shouldn't be able.

[Tryskell]

Changeset 230

Numerous cleanups on clientpackets, misc

Clientpackets
   - addition of null checks (around 20, if not more), "final" keyword.
   - drop of the personal Logger for each clientpacket, they share the same now.
   - reworked a couple of packets : checks better placed, better use of variables when possible, etc.
   
Misc
   - addition of TradeItemUpdate serverpacket, based on L2JBroken one (and surely based on another russian pack), ty Kenrix.
   - fix the problem with olympiads tokens and fix the message aswell (ty McMaGo, Brucutu, SweeTs for reports).
   - some XMLs tables are refreshed ; less objects created.

[Tryskell]

Changeset 231

Quests, misc

Quests
   - Addition of Q023, Q364 && Q378.
   - Fix 2 issues in Q021.
   
Misc
   - Fix 9 SoEs and 5 others items (needed core support aswell).
   - Don't launch a pvp flag task if one already exists.
   - Don't autoattack (some skills got that behavior) if target isn't autoattackable.
   - Cleanup valueOf => parseInt/Long/Boolean (surely more to do, only in Config atm).
   - You don't lose your buffs anymore if you cancel the autoress from PheonixBless type skills (but you still lose PhoenixBless effect && Noblesse).