aCis


Beginning of the cycle 380-389. Current focus : exploit fixes, scripts ending. Changeset 380 (1133) is up !

Last aCis updates

Tryskell · 280 · 224136

Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #45 on: April 29, 2011, 06:45:28 AM
Changeset 90

    NoStore? implementation + 2 messages, ty Zerador for initial patch.

    NoStore?

        only the jail and both Oracles (dusk/dawn) are setup as NoStore? zones.
        both private stores (buy/sell) and private manufactures (dwarven/general) are blocked.

    Privates stores/manufactures

        got more and shared conditions (must be unmounted, not in nostore zone, be alive,...)
        some packets clean, and one exploit fix.


    2 messages added

        when one of your blow fails;
        when you avoid the attack of character xx.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #46 on: April 29, 2011, 07:33:20 PM
Changeset 91

    Couple of fixes for pets/summons

        L2SummonAI refactor (enjoy the 10sec Freya copy-paste), which adds the "avoidTask" feature (when your pet is hitted, he moves around you);
        teleport is fixed with a pet (pet is ported with you);
        if the pet is 20 lvls more than you or a wyvern/sin eater, you can't make it attack;
        couple of fixes in the different summons/pets actions aswell (follow, stop, attack);
        pet follows you when you summon him for the first time (before it was standing like a tree);

    Misc

        some cleanings in L2NpcWalkerAI.

Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #47 on: April 30, 2011, 08:51:07 PM
Changeset 92

XMLization !

We got another XMLlizer, treaser :P. Ty to him for those 2 shares.

    2 tables are now XMLs, teleport and newbie buffs.
    Reorganisation of XMLs (data/xml).
    Couple of little fixes, such as Config.DATAPACK_ROOT and unification of XMLs errors messages.


Added protection blessing core support. Wait for 5100-5199 for effect.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #48 on: May 03, 2011, 12:12:00 AM
Changeset 93

Inventories update, part I

    update each type of inventory.
    correct items consumption problems.
    fix around 10 different issues, such as bad synchronizing, freight exploits && missing checks.
    inventories (mainly normal inventory and freight) are loaded FAR faster.
    added not 1, not 2, but 3 configs ! Ooooohhhhh !


Break definitively augmentations, which still need a complete refactor. The pet inventory isn't supported yet aswell (need PetTable? and model entire refactor).

Tested skills consumptions, and the triforce (WH, CWH, and freight). Anyway, report if errors occur.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #49 on: May 06, 2011, 05:08:40 AM
Changeset 94

Inventories update, part II

I warn you : this update is pretty huge. Well, you could think "he says that to each commit nowadays", lol, and the worst is : you're right, as I'm right saying it's huge :D.

Inventory refactor
   - Paperdolls refactors, LRHAND dissapears (not the slot !). Bows/staff are now considered as RHAND.
   - DHAIR => HAIRALL. Just to understand better 'what the hell is this crap'.
   - inventories instanciation. Should make sad some exploiters.
   - formal wear retail way (alldress slot).
   
TradeList refactor
   - refactor the buylists loading (no more .csv support).
   - correct and improve (adding checks, using fun stuff) packets using them. Add some checks, those sorts of stuff.
   
"Wear/Try on" system
   - Drop of the old "wear/try on" system, and of all old methods (isWear, and such).
   - The new one is buggy as I miss packets infos, and the only infos come from Freya (this stuff has been implemented on L2J around rev 44xx). WearList > ShopPreviewList, and added a new packet, ShopPreviewInfo.
   - The new system doesn't need checks as it's only a packet which change the appearance of your stuff. Basically not exploitable, and extremely light in ressources' usages (before an item was created, used, then deleted).

Misc
   - L2ManorManager refactor (warning : as I suck with manors uses, I didn't manage to test crops/seeds sell/buy etc. I would like someone teach me how this crap works one day, lol).
   - refactor of the way to count arrows.
   - some packets refactors (mainly RequestCrystallizeItem), and many cleans.
   - a GM can't use hero weapons anymore if he isn't a hero himself, in order to avoid the "stupid bug" at relog, which made me lose 30min to find why it happened (and when a inventory refactor comes, you're pretty nervous about "WHY THE FOCK THIS STUPID HERO BOW IS REMOVED AT RELOG AND NOT OTHERS WEAPONS ?).
   - correction of a couple (around 10) of logs names... Ty Sentinel to open my eyes on this awful critical issue which could destroy the Earth and humanity. Which isn't a awful critical issue which could destroy the Earth and humanity, but still make you cry.
   
Admin commands
   - ended the refactor of AdminEditNpc (both "edit" and "shop" parts have been corrected and improved).
   - AdminEnchant send only one message if you're the target.

And once again :
REPORT ON GODAMN FORUM IF ERRORS OCCUR, DONT CRY ON MXC THREAD XAXA.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #50 on: May 08, 2011, 04:54:56 AM
Changeset 95

    Inventories update, part III


    Warehouses
        Warehouses clientpackets updates

    ClanHalls?
        ClanHallManager? refactor
        mana consumption for CH buffs corrected
        teleports lists corrected and/or added (schuttgard was missing) using Freya.

    Misc
        StatusUpdate? update.



Changeset 96

ArmorSets? table XMLization, ty treaser (my treasure ;o) for initial share.
« Last Edit: May 08, 2011, 02:13:24 PM by Tryskell »
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #51 on: May 11, 2011, 08:27:04 PM
Changeset 97

XMLization of pet_stats, plus a couple of rework.

Many values are now automatically calculated, not loaded from table. I need to experiment and debug a lot on this side, as calculations seem incorrect.

Pets got many problems anyway.


Changeset 98

Move of zone.xml in xml folder, plus a little clean on ZoneManager?.
« Last Edit: May 12, 2011, 05:39:58 PM by Tryskell »
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #52 on: May 12, 2011, 05:40:28 PM
Changeset 99

4200-4299, ty SweeTs? for initial work.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #53 on: May 13, 2011, 09:54:19 PM
Changeset 100

Pets refactor, part II

- Reorganization of the XML and loading process
- Update of the FeedTask?, with now the possibility of pet deletion if it is hungry (30% => 5% luck, 10% => 30% luck).
- Some stuff which will be used when items refactor will come.
- Hungry state setup to 55% (will be used for autoconsumption of food).

Pets are still heavily broken (3 major problems), and they need items refactors from now (currently, food isn't considered as pet item).


Changeset 101

FishTable XMLization, ty treaser for initial share.

- XMLization of fish.sql => fishes.xml
- To respect naming conventions in the XML folder, zone.xml => zones.xml
« Last Edit: May 14, 2011, 12:17:58 AM by Tryskell »
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #54 on: May 14, 2011, 12:08:53 PM
Changeset 102

Augmentations refactor

Yeah, fully working. What more to say...
- augmentations are added when unequip/equip items, and loaded with inventory.
- I used Freya, and deleted all accessories part, plus useless stuff (yellow array, useless method,...)
- augments are now deleted with items, when a character is deleted aswell.
- active augments got their cooltime stored.
- some security checks added in concerned packets.

About DP :
- c/p of the skillmap (go from 58ko to ~530ko)
- if there are problems about eventual postIL skills, tell me on forum. But from what I know, all are in the 3100/3200/3300.
- added a couple of configs.

Misc :
- drop of getItemGrade(), which called getCrystalType(). Why it existed, I have sincerly no idea. And you can't say dev was drunked, because he did the javadoc, and said on it "it is the same". Lol.
- mini reorganization in Config.java, in order to make lines less big. Just spaces basically.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #55 on: May 15, 2011, 03:36:44 AM
Changeset 103

ClanHalls refactor + Singletons

Well, it begun with a correction of singletons, and it ends by a clanhall update :).

CHs / Auctions
   - Added the missing 22th auction, (Gludio or gludin) Moonstone Hall.
   - Corrected CHs loading process (Contestable aren't considered as auctionable)
   - Corrected week leases of all CHs (c/p freya), and descriptions.
   - Many typos, improvements and singletonizations of related instances.
   
Misc
   - Some singletonizations.
   - Added RequestExMagicSkillUseGround packet content (signets), ty Zerador for info.
   - Manufacturing checks are now made in clientpacket, not in serverpacket.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #56 on: May 18, 2011, 03:41:14 AM
Changeset 104

Cursed weapons refactor, 1 skill XML

CWs
   - added propers messages at cursed owner login;
   - debugged cw_add (missing time task activation, and bug when you added 2 weapons on same character);
   - singletonizations, typos, missing checks, code actualization;
   - cursedWeapons.xml renamed cursed_weapons.xml, following the general XML naming convention.
   - GrandBosses, feeded beasts and guards can't drop them.

Misc
   - All freakin typos errors "equiped"/"unequiped" are now "equipped"/"unequipped".
   - "DropIt" => "dropIt"
   - refreshed the reward method (doItemDrop) in L2Attackable.
   - Added 5100-5199 (signets working without force condition, but they work);
   
Go post "Tryskell is right, you're all noobs" here : http://www.l2jserver.com/forum/viewtopic.php?f=82&t=22092
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #57 on: May 19, 2011, 02:10:54 AM
Changeset 105

4600-4699 xml + core support



Changeset 106

Last skill XML is now commited : 4700-4799.

From now, and for any skill behavior/values, you can post problems on the unique topic "skills problem", in "reports CORE errors" section.
« Last Edit: May 19, 2011, 12:11:19 PM by Tryskell »
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #58 on: May 19, 2011, 12:11:23 PM
Changeset 107

ConfirmDlg? refactor, SummonFriend? fix

- you can now add multiple things in ConfirmDlg? (popups for ress, summon friends, wedding accept). Timer, Zone area and many more are now supported.
- Timer (30 seconds) and requesterId (fix bugged accept issue) added for Summon Friend. The popup shows too the zone where the requester is.
- corrected an issue (when charm of courage will work, it would make the accept button buggy aswell).
- modified the generic wedding popup generic for another (normally correct the "?" typo).


Misc
- IsInCombat? fix. Fix "pets stuck in combat" issue (couldn't unsummon if you "attack" then "stop" the attack before the pet attacks).



Changeset 108

AdminCommands? refactor, HTMs spring clean

  • deletion of //set (if I got many whines on forum, I will add it back, but not on this version anyway). I know it can be useful (modifying configs ingame directly), but not this form (or you have to memorize each godamn config).
  • drop of AdminTest? ; the only survivor, //st, has been moved to AdminSkill?.
  • merge of AdminShutdown? && AdminLogin? (read DP side).

DP side

  • remove of //recall_npc ghost button
  • accountinfo cleaned, charskills updated (add of removereuse button + broken link fix)
  • merge of shutdown && login, to maintenance



Changeset 109

Skills fixes (signets restrictions, ChanceSkillTrigger)

   - ChanceSkillTrigger debug (work now on any L2Character instead of L2Playable). Debug mirage and all augments using this type of effects.
   - RemoveTarget effect now deletes completely the attackstance (it was keeping attacking even with target off, lol).
   - Added back Battle/SpellForce.
   - Deleted EffectForce. Old ruin of past memories. Or something like "very very old thing" :).
   - Added right conditions for signets cast. They now work (near) as they should.
   
I decided to use the generic "work everywhere" systemMessage 113 for skill's unavailable forces number condition. If you find a cooler or the exact message (if it's the wrong message), tell me.

In another hand, if you think I missed a check on FusionSkill, tell me aswell. Don't wait 40 revs to say "hey, you got a problem here". It normally checks following states : death, under attack, party break, subclass change.
« Last Edit: May 19, 2011, 08:34:12 PM by Tryskell »
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>


Offline Tryskell

  • The cute dwarf
  • *
    • Posts: 3.881
    • Cookies: +34/-2
Reply #59 on: May 20, 2011, 06:05:42 PM
Changeset 110

Zone update

    L2PoisonZone is renamed for L2EffectZone (and reworked...).
    Skills affect only L2Playable instances type (summons and players).
    Remove a warning on L2DamageZone (no effects).


DP

    Add an debuff effect on Orfen Lair ;p. Added to the swamp effect, you're really lame now.
    Renamed the 167 PoisonZones?, nothing more.


Should correct this issue :  http://img541.imageshack.us/img541/3423/erroria.jpg
If skills XMLs end didn't do it.
Code: [Select]
<html><body>Triskel:<br>
Triskel does not speak with foolish fellows who do not know their profession!
</body></html>